From: Tony Lindgren <tony@atomide.com>
To: Felipe Balbi <me@felipebalbi.com>
Cc: H?gander Jouni <jouni.hogander@nokia.com>, linux-omap@vger.kernel.org
Subject: Re: [PATCH 0/4] Refreshed PM workaround patches 2.
Date: Mon, 18 Aug 2008 16:23:22 +0300 [thread overview]
Message-ID: <20080818132321.GJ17827@atomide.com> (raw)
In-Reply-To: <20080815074937.GI16231@frodo>
* Felipe Balbi <me@felipebalbi.com> [080815 10:50]:
> On Fri, Aug 15, 2008 at 10:44:47AM +0300, H?gander Jouni wrote:
> > Refreshed PM workaround set without coding style errors and 24xx build
> > fixed. Here are instructions how to test them:
> >
> > To get Omap into retention, this patch set still depends on:
> > 1. ARCH: OMAP: MUSB: Do not block sleep (Felipe Balbi)
>
> I thought it had been applied. Probably lost while tony was on
> vacations. Anyways, here it is:
Thanks, pushing today.
Tony
> From: Felipe Balbi <felipe.balbi@nokia.com>
>
> arch: omap: usb: do not block sleep
>
> musb_set_clock should not block sleep on omap3-based
> boards, it prevents system from sleeping.
>
> Thanks to Jouni Högander for pointing this out
>
> Signed-off-by: Felipe Balbi <felipe.balbi@nokia.com>
> ---
>
> diff --git a/arch/arm/mach-omap2/usb-musb.c b/arch/arm/mach-omap2/usb-musb.c
> index 71ddf55..3f90a93 100644
> --- a/arch/arm/mach-omap2/usb-musb.c
> +++ b/arch/arm/mach-omap2/usb-musb.c
> @@ -58,7 +58,6 @@ static int musb_set_clock(struct clk *clk, int state)
> if (clk_on > 0)
> return -ENODEV;
>
> - omap2_block_sleep();
> clk_enable(clk);
> clk_on = 1;
> } else {
> @@ -67,7 +66,6 @@ static int musb_set_clock(struct clk *clk, int state)
>
> clk_disable(clk);
> clk_on = 0;
> - omap2_allow_sleep();
> }
>
> return 0;
>
> --
> balbi
> --
> To unsubscribe from this list: send the line "unsubscribe linux-omap" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
prev parent reply other threads:[~2008-08-18 13:23 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-15 7:44 [PATCH 0/4] Refreshed PM workaround patches 2 Högander Jouni
2008-08-15 7:47 ` [PATCH 1/4] 34XX: PM: Workaround to check wether any fck is active before entering sleep Jouni Hogander
2008-08-20 11:35 ` Tony Lindgren
2008-08-22 5:45 ` Högander Jouni
2008-08-22 18:07 ` Tony Lindgren
2008-08-21 8:17 ` Rajendra Nayak
2008-08-21 9:41 ` Rajendra Nayak
2008-08-15 7:47 ` [PATCH 2/4] PM: Workaround for taking care of gpio clocks Jouni Hogander
2008-08-20 11:37 ` Tony Lindgren
2008-08-21 11:07 ` Tero.Kristo
2008-08-22 18:06 ` Tony Lindgren
2008-08-15 7:47 ` [PATCH 3/4] Added sleep support to UART Jouni Hogander
2008-08-20 11:40 ` Tony Lindgren
2008-08-20 12:26 ` Tero.Kristo
2008-08-15 7:47 ` [PATCH 4/4] 34XX: PM: Workaround to enable autoidle for clocks and plls Jouni Hogander
2008-08-20 11:51 ` Tony Lindgren
2008-08-15 7:49 ` [PATCH 0/4] Refreshed PM workaround patches 2 Felipe Balbi
2008-08-18 13:23 ` Tony Lindgren [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080818132321.GJ17827@atomide.com \
--to=tony@atomide.com \
--cc=jouni.hogander@nokia.com \
--cc=linux-omap@vger.kernel.org \
--cc=me@felipebalbi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox