Re: [PATCH] Fix isp1301_omap compile (Re: testers wanted: isp1301_omap conversion to new-style i2c driver)

[Jean Delvare <khali@linux-fr.org>]

On Mon, 18 Aug 2008 15:21:45 +0300, Tony Lindgren wrote:
> * Jean Delvare <khali@linux-fr.org> [080812 12:52]:
> > Hi Tony,
> > 
> > On Tue, 12 Aug 2008 12:29:18 +0300, Tony Lindgren wrote:
> > > * David Brownell <david-b@pacbell.net> [080811 21:35]:
> > > > > That one isn't mine, the original code already has the problem.
> > > > > Apparently this was broken by the following patch from David:
> > > > >
> > > > > 	f35ae6346850f6c192269b09088b20261760f0e0
> > > > 
> > > > Tony, actually ... there were some issues in the omap_udc code too.
> > > 
> > > Yeah, blame it on me, looks like I missed that one somehow with the
> > > __REG removal.
> > > 
> > > > > The fix should be sent to Linus ASAP, otherwise the driver won't build
> > > > > in 2.6.27. You have my ack.
> > > 
> > > Can you send it via your I2C? Let me know if your want me to send it
> > > via arm-omap fixes.
> > 
> > Please take care of it. The patch that broke the driver came through
> > your tree so I think it makes more sense to have the fix come through
> > your tree as well.
> 
> Well looks like there's already cbbcb9b0c7e4d1fd90cf54427382dae525773dc2
> taking care of it the second part of my earlier patch.
> 
> But the following patch still needs to be merged into Felipe's
> "2c/isp1301_omap: Convert to a new-style i2c driver, part 1" patch.

I've done that already.

-- 
Jean Delvare