Re: [PATCH 14/16] ARM: OMAP2: Misc updates from linux-omap tree

[Tony Lindgren <tony@atomide.com>]

* Russell King - ARM Linux <linux@arm.linux.org.uk> [080820 00:08]:
> On Fri, Jun 06, 2008 at 07:12:40PM -0700, Tony Lindgren wrote:
> > @@ -208,10 +365,12 @@ static int __init omap2_init_devices(void)
> >  	/* please keep these calls, and their implementations above,
> >  	 * in alphabetical order so they're easier to sort through.
> >  	 */
> > -	omap_init_i2c();
> > +	omap_init_camera();
> >  	omap_init_mbox();
> >  	omap_init_mcspi();
> > +	omap_hdq_init();
> >  	omap_init_sti();
> > +	omap_init_sha1_md5();
> >  
> >  	return 0;
> >  }
> 
> Hmm, looking through this file, looking at:
> 1. the conditionals on the machine type
> 2. the CONFIG_ dependencies for CPU driver versions
> 
> and then considering... what if a platform only supports one mcspi,
> should we be registering all mcspi's...
> 
> Wouldn't it be better to let the platforms themselves decide which
> devices should be registered, just like AT91 does and now PXA?

Yes, the struct omap2_mcspi_device_config is already coming from
board-*.c files. But the mach-omap2/board-*.c files will be coming
after the core code has been merged.

> > +#ifndef __ASM_ARCH_CONTROL_H
> > +#define __ASM_ARCH_CONTROL_H
> > +
> >  #include <asm/arch/io.h>
> >  
> > +#ifndef __ASSEMBLY__
> >  #define OMAP242X_CTRL_REGADDR(reg)					\
> > -	(void __iomem *)IO_ADDRESS(OMAP242X_CTRL_BASE + (reg))
> > +	(__force void __iomem *)IO_ADDRESS(OMAP242X_CTRL_BASE + (reg))
> >  #define OMAP243X_CTRL_REGADDR(reg)					\
> > -	(void __iomem *)IO_ADDRESS(OMAP243X_CTRL_BASE + (reg))
> > +	(__force void __iomem *)IO_ADDRESS(OMAP243X_CTRL_BASE + (reg))
> >  #define OMAP343X_CTRL_REGADDR(reg)					\
> > -	(void __iomem *)IO_ADDRESS(OMAP343X_CTRL_BASE + (reg))
> > +	(__force void __iomem *)IO_ADDRESS(OMAP343X_CTRL_BASE + (reg))
> 
> There's those big warning casts again.  If you moved that inside
> IO_ADDRESS() then you wouldn't need all these #ifndef __ASSEMBLY__
> stuff whereever you use that macro.

Will remove these. I have some mach/io.h clean up patches coming up for
the next merge window that should take care of this.

Ton