From: Tony Lindgren <tony@atomide.com>
To: Felipe Balbi <felipe.balbi@nokia.com>
Cc: ext Hiroshi DOYU <Hiroshi.DOYU@nokia.com>,
linux-omap@vger.kernel.org, paul@pwsan.com,
eduardo.valentin@indt.org.br
Subject: Re: [PATCH 1/2] CLK: Introduce virtual clock registration
Date: Wed, 20 Aug 2008 14:54:00 +0300 [thread overview]
Message-ID: <20080820115400.GF29374@atomide.com> (raw)
In-Reply-To: <20080820101812.GK23346@gandalf.research.nokia.com>
* Felipe Balbi <felipe.balbi@nokia.com> [080820 13:17]:
> On Wed, Aug 20, 2008 at 12:51:51PM +0300, Hiroshi DOYU wrote:
> > +int vclk_enable(struct clk *clk)
> > +{
> > + int i;
> > + struct vclk *vc = container_of(clk, struct vclk, clk);
> > +
> > + for (i = 0; i < vc->n_childs; i++)
> > + clk_enable(vc->childs[i]);
>
> missing an error check for clk_enable()
And disable all virtual clocks if any of them fail?
Looks good other than that.
Tony
next prev parent reply other threads:[~2008-08-20 11:54 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-20 9:51 [PATCH 1/2] CLK: Introduce virtual clock registration Hiroshi DOYU
2008-08-20 9:51 ` [PATCH 2/2] CLK: Use virtual clock register for mcbsp clock Hiroshi DOYU
2008-08-20 10:04 ` [PATCH 1/2] CLK: Introduce virtual clock registration Daniel Stone
2008-08-20 11:15 ` Hiroshi DOYU
2008-08-20 10:18 ` Felipe Balbi
2008-08-20 11:54 ` Tony Lindgren [this message]
-- strict thread matches above, loose matches on Subject: below --
2008-08-20 12:04 Hiroshi DOYU
2008-08-20 19:10 ` Eduardo Valentin
2008-08-21 9:57 ` Hiroshi DOYU
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080820115400.GF29374@atomide.com \
--to=tony@atomide.com \
--cc=Hiroshi.DOYU@nokia.com \
--cc=eduardo.valentin@indt.org.br \
--cc=felipe.balbi@nokia.com \
--cc=linux-omap@vger.kernel.org \
--cc=paul@pwsan.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox