Re: [PATCH] OMAP:MUSB: Fixes the TT programming.

[David Brownell <david-b@pacbell.net>]

On Thursday 21 August 2008, ajay.gupta@ti.com wrote:
> From: Ajay Kumar Gupta <ajay.gupta@ti.com>
> 
> Fixes enumeration failures when a USB device attached to a LS hub
> is connected to OMAP EVM via HS hub. This is fixed by correctly
> programming hub address register in enqueue path.  
> 
> Signed-off-by: Ajay Kumar Gupta <ajay.gupta@ti.com>

Looks right to me, other than the lack of line wrapping in that
summary (corrected above).  Moreover, there ought to be some way
to make all high speed hosts share TT scheduling code ... ;)

Acked-by: David Brownell <dbrownell@users.sourceforge.net>


> ---
>  drivers/usb/musb/musb_host.c |    6 +++++-
>  1 files changed, 5 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/usb/musb/musb_host.c b/drivers/usb/musb/musb_host.c
> index 52ac02a..90d3733 100644
> --- a/drivers/usb/musb/musb_host.c
> +++ b/drivers/usb/musb/musb_host.c
> @@ -1869,7 +1869,11 @@ static int musb_urb_enqueue(
>  			/* set up tt info if needed */
>  			if (urb->dev->tt) {
>  				qh->h_port_reg = (u8) urb->dev->ttport;
> -				qh->h_addr_reg |= 0x80;
> +				if (urb->dev->tt->hub)
> +					qh->h_addr_reg =
> +						(u8) urb->dev->tt->hub->devnum;
> +				if (urb->dev->tt->multi)
> +					qh->h_addr_reg |= 0x80;
>  			}
>  		}
>  	}
> -- 
> 1.5.6
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-usb" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>