[PATCH] OMAP:MUSB: Fixes the TT programming.

[PATCH] OMAP:MUSB: Fixes the TT programming.

[ajay.gupta-l0cyMroinI0]

From: Ajay Kumar Gupta <ajay.gupta-l0cyMroinI0@public.gmane.org>

Fixes enumeration failures when a USB device attached to a LS hub is connected to OMAP EVM via HS hub. This is fixed by correctly programming hub address register in enqueue path.

Signed-off-by: Ajay Kumar Gupta <ajay.gupta-l0cyMroinI0@public.gmane.org>
---
 drivers/usb/musb/musb_host.c |    6 +++++-
 1 files changed, 5 insertions(+), 1 deletions(-)

diff --git a/drivers/usb/musb/musb_host.c b/drivers/usb/musb/musb_host.c
index 52ac02a..90d3733 100644
--- a/drivers/usb/musb/musb_host.c
+++ b/drivers/usb/musb/musb_host.c
@@ -1869,7 +1869,11 @@ static int musb_urb_enqueue(
 			/* set up tt info if needed */
 			if (urb->dev->tt) {
 				qh->h_port_reg = (u8) urb->dev->ttport;
-				qh->h_addr_reg |= 0x80;
+				if (urb->dev->tt->hub)
+					qh->h_addr_reg =
+						(u8) urb->dev->tt->hub->devnum;
+				if (urb->dev->tt->multi)
+					qh->h_addr_reg |= 0x80;
 			}
 		}
 	}
-- 
1.5.6

--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] OMAP:MUSB: Fixes the TT programming.

[David Brownell]

On Thursday 21 August 2008, ajay.gupta@ti.com wrote:
> From: Ajay Kumar Gupta <ajay.gupta@ti.com>
> 
> Fixes enumeration failures when a USB device attached to a LS hub
> is connected to OMAP EVM via HS hub. This is fixed by correctly
> programming hub address register in enqueue path.  
> 
> Signed-off-by: Ajay Kumar Gupta <ajay.gupta@ti.com>

Looks right to me, other than the lack of line wrapping in that
summary (corrected above).  Moreover, there ought to be some way
to make all high speed hosts share TT scheduling code ... ;)

Acked-by: David Brownell <dbrownell@users.sourceforge.net>


> ---
>  drivers/usb/musb/musb_host.c |    6 +++++-
>  1 files changed, 5 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/usb/musb/musb_host.c b/drivers/usb/musb/musb_host.c
> index 52ac02a..90d3733 100644
> --- a/drivers/usb/musb/musb_host.c
> +++ b/drivers/usb/musb/musb_host.c
> @@ -1869,7 +1869,11 @@ static int musb_urb_enqueue(
>  			/* set up tt info if needed */
>  			if (urb->dev->tt) {
>  				qh->h_port_reg = (u8) urb->dev->ttport;
> -				qh->h_addr_reg |= 0x80;
> +				if (urb->dev->tt->hub)
> +					qh->h_addr_reg =
> +						(u8) urb->dev->tt->hub->devnum;
> +				if (urb->dev->tt->multi)
> +					qh->h_addr_reg |= 0x80;
>  			}
>  		}
>  	}
> -- 
> 1.5.6
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-usb" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 

Re: [PATCH] OMAP:MUSB: Fixes the TT programming.

[Greg KH]

On Thu, Aug 21, 2008 at 11:30:06PM -0700, David Brownell wrote:
> On Thursday 21 August 2008, ajay.gupta-l0cyMroinI0@public.gmane.org wrote:
> > From: Ajay Kumar Gupta <ajay.gupta-l0cyMroinI0@public.gmane.org>
> > 
> > Fixes enumeration failures when a USB device attached to a LS hub
> > is connected to OMAP EVM via HS hub. This is fixed by correctly
> > programming hub address register in enqueue path.  
> > 
> > Signed-off-by: Ajay Kumar Gupta <ajay.gupta-l0cyMroinI0@public.gmane.org>
> 
> Looks right to me, other than the lack of line wrapping in that
> summary (corrected above).  Moreover, there ought to be some way
> to make all high speed hosts share TT scheduling code ... ;)
> 
> Acked-by: David Brownell <dbrownell-Rn4VEauK+AKRv+LV9MX5uipxlwaOVQ5f@public.gmane.org>

Ok, for all MUSB patches, I'm going to wait until Felipe tells me to
accept them, as he's the subsystem/driver maintainer.

Felipe, is this ok?  Can you just bundle up what you feel is good and
send them to me when they are ready (usually as soon as possible)?

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] OMAP:MUSB: Fixes the TT programming.

[Felipe Balbi]

On Sun, Aug 24, 2008 at 08:53:22PM -0700, Greg KH wrote:
> On Thu, Aug 21, 2008 at 11:30:06PM -0700, David Brownell wrote:
> > On Thursday 21 August 2008, ajay.gupta@ti.com wrote:
> > > From: Ajay Kumar Gupta <ajay.gupta@ti.com>
> > > 
> > > Fixes enumeration failures when a USB device attached to a LS hub
> > > is connected to OMAP EVM via HS hub. This is fixed by correctly
> > > programming hub address register in enqueue path.  
> > > 
> > > Signed-off-by: Ajay Kumar Gupta <ajay.gupta@ti.com>
> > 
> > Looks right to me, other than the lack of line wrapping in that
> > summary (corrected above).  Moreover, there ought to be some way
> > to make all high speed hosts share TT scheduling code ... ;)
> > 
> > Acked-by: David Brownell <dbrownell@users.sourceforge.net>
> 
> Ok, for all MUSB patches, I'm going to wait until Felipe tells me to
> accept them, as he's the subsystem/driver maintainer.
> 
> Felipe, is this ok?  Can you just bundle up what you feel is good and
> send them to me when they are ready (usually as soon as possible)?

Ok. I'll queue them today and send to you in a few hours.

-- 
balbi