From: Felipe Balbi <me@felipebalbi.com>
To: Felipe Balbi <me@felipebalbi.com>
Cc: David Brownell <david-b@pacbell.net>,
felipe.balbi@nokia.com, ext Ashwin Bihari <abihari@gmail.com>,
linux-omap@vger.kernel.org
Subject: Re: Enabling MUSB support
Date: Fri, 29 Aug 2008 23:33:56 +0300 [thread overview]
Message-ID: <20080829203353.GB14130@frodo> (raw)
In-Reply-To: <20080829202114.GA14130@frodo>
On Fri, Aug 29, 2008 at 11:21:16PM +0300, Felipe Balbi wrote:
> diff --git a/drivers/usb/musb/musb_core.c b/drivers/usb/musb/musb_core.c
> index b398776..bcd0832 100644
> --- a/drivers/usb/musb/musb_core.c
> +++ b/drivers/usb/musb/musb_core.c
> @@ -534,15 +534,15 @@ static irqreturn_t musb_stage0_irq(struct musb *musb, u8 int_usb,
> */
> case OTG_STATE_A_WAIT_BCON:
> case OTG_STATE_A_WAIT_VRISE:
> - if (musb->vbuserr_retry) {
> - musb->vbuserr_retry--;
> + while(--vbuserr_retry) {
> ignore = 1;
> devctl |= MUSB_DEVCTL_SESSION;
> musb_writeb(mbase, MUSB_DEVCTL, devctl);
> - } else {
> - musb->port1_status |=
> - (1 << USB_PORT_FEAT_OVER_CURRENT)
> - | (1 << USB_PORT_FEAT_C_OVER_CURRENT);
> +
> + if (vbuserr_retry == 0)
for both I meant musb->vbuserr_retry, sorry.
> + musb->port1_status |=
> + (1 << USB_PORT_FEAT_OVER_CURRENT)
> + | (1 << USB_PORT_FEAT_C_OVER_CURRENT);
> }
> break;
> default:
>
> Didn't test though. If it works nicely, the same logic will have to go
> to tusb6010.c
>
> --
> balbi
--
balbi
next prev parent reply other threads:[~2008-08-29 20:34 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-27 13:26 Enabling MUSB support Ashwin Bihari
2008-08-27 13:38 ` Felipe Balbi
2008-08-27 13:51 ` Ashwin Bihari
2008-08-27 13:55 ` Felipe Balbi
2008-08-27 14:10 ` Gadiyar, Anand
2008-08-28 6:54 ` David Brownell
2008-08-28 7:58 ` Koen Kooi
2008-08-28 8:02 ` Gadiyar, Anand
2008-09-02 22:37 ` Tony Lindgren
2008-08-28 9:07 ` Felipe Balbi
2008-08-28 10:19 ` Gadiyar, Anand
2008-08-28 10:28 ` Felipe Balbi
2008-08-28 11:20 ` Felipe Balbi
2008-08-29 4:41 ` Gupta, Ajay Kumar
2008-08-29 4:50 ` Gadiyar, Anand
2008-08-29 7:49 ` Felipe Balbi
2008-08-29 8:36 ` Gadiyar, Anand
2008-08-29 9:18 ` Felipe Balbi
2008-08-29 9:23 ` Gadiyar, Anand
2008-08-29 9:25 ` Felipe Balbi
2008-08-29 9:32 ` Gadiyar, Anand
2008-08-29 18:12 ` David Brownell
2008-08-29 19:00 ` Felipe Balbi
2008-08-29 20:05 ` David Brownell
2008-08-29 20:21 ` Felipe Balbi
2008-08-29 20:33 ` Felipe Balbi [this message]
2008-08-29 20:50 ` David Brownell
2008-08-29 20:59 ` Felipe Balbi
2008-09-07 20:22 ` David Brownell
2008-09-02 22:36 ` Tony Lindgren
2008-08-27 13:40 ` Gadiyar, Anand
2008-08-27 13:53 ` Ashwin Bihari
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080829203353.GB14130@frodo \
--to=me@felipebalbi.com \
--cc=abihari@gmail.com \
--cc=david-b@pacbell.net \
--cc=felipe.balbi@nokia.com \
--cc=linux-omap@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox