From: David Brownell <david-b@pacbell.net>
To: "Woodruff, Richard" <r-woodruff2@ti.com>
Cc: "linux-omap@vger.kernel.org" <linux-omap@vger.kernel.org>
Subject: Re: [patch 2.6.27-rc3-omap1] omap3 beagle: nand (mostly) cleanups
Date: Fri, 29 Aug 2008 21:23:15 -0700 [thread overview]
Message-ID: <200808292123.15916.david-b@pacbell.net> (raw)
In-Reply-To: <13B9B4C6EF24D648824FF11BE896716203653CA11D@dlee02.ent.ti.com>
On Friday 29 August 2008, Woodruff, Richard wrote:
> > Clean up the Beagle NAND config a bit: use SZ_128K instead of
> > an arithmetic expression for the NAND block size. Set the
> > NAND_BUSWIDTH_16 flag. Make its init routine static.
>
>
> Actually, this was talked about before a bit and the SZ_xyz flags were left out.
>
> The point of telling the geometry in the addition was to be explicit
> about the number of sectors being used.
So #define NAND_BLOCK_SIZE SZ_128K and use that symbol instead?
Frankly N*(64 * 2048) isn't very meaningful. The comment at the
top already says everything is in units of blocks, but one is left
to guess that "block" is "(64 * 2048)"...
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2008-08-30 4:23 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-29 17:12 [patch 2.6.27-rc3-omap1] omap3 beagle: nand (mostly) cleanups David Brownell
2008-08-29 23:56 ` Woodruff, Richard
2008-08-30 4:23 ` David Brownell [this message]
2008-09-02 17:23 ` David Brownell
2008-09-02 17:31 ` Woodruff, Richard
2008-09-05 16:43 ` Tony Lindgren
2008-09-02 18:46 ` Steve Sakoman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200808292123.15916.david-b@pacbell.net \
--to=david-b@pacbell.net \
--cc=linux-omap@vger.kernel.org \
--cc=r-woodruff2@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox