From: Russell King - ARM Linux <linux@arm.linux.org.uk>
To: Sanjeev Premi <premi@ti.com>
Cc: linux-omap@vger.kernel.org
Subject: Re: [PATCH 2/3] Runtime check for OMAP35x
Date: Mon, 1 Sep 2008 21:10:58 +0100 [thread overview]
Message-ID: <20080901201058.GE28999@flint.arm.linux.org.uk> (raw)
In-Reply-To: <1220299067-17307-2-git-send-email-premi@ti.com>
On Tue, Sep 02, 2008 at 01:27:46AM +0530, Sanjeev Premi wrote:
> Based on earlier review comments, added runtime
> check of the OMAP35x via omap2_set_globasl_3503() etc.
> ---
> arch/arm/plat-omap/common.c | 76 ++++++++++++++++++++++++++++++++++
> include/asm-arm/arch-omap/common.h | 4 ++
> include/asm-arm/arch-omap/cpu.h | 79 ++++++++++++++++++++++++++++++++++++
> 3 files changed, 159 insertions(+), 0 deletions(-)
>
> diff --git a/arch/arm/plat-omap/common.c b/arch/arm/plat-omap/common.c
> index 3a5f05e..f8b04cc 100644
> --- a/arch/arm/plat-omap/common.c
> +++ b/arch/arm/plat-omap/common.c
> @@ -334,3 +334,79 @@ void __init omap2_set_globals_343x(void)
> }
> #endif
>
> +#if defined(CONFIG_ARCH_OMAP3503)
> +
> +static struct omap_globals omap3503_globals = {
> + .class = OMAP35XX_CLASS,
> + .tap = (__force void __iomem *)OMAP2_IO_ADDRESS(0x4830A000),
See my comments elsewhere about why this is Really Bad. Any casts
outside of a few header files using __force are basically a bug.
In this case, you're being forced to use them because OMAP2_IO_ADDRESS
doesn't return the proper pointer values. (I produced a patch for
comment on this list last week over this issue.)
next prev parent reply other threads:[~2008-09-01 20:11 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-09-01 19:57 [PATCH 1/3] Add support for OMAP35x processors Sanjeev Premi
2008-09-01 19:57 ` [PATCH 2/3] Runtime check for OMAP35x Sanjeev Premi
2008-09-01 20:10 ` Russell King - ARM Linux [this message]
2008-09-02 6:29 ` Premi, Sanjeev
2008-09-02 17:30 ` Premi, Sanjeev
2008-09-01 19:57 ` [PATCH 3/3] Updates to OMAP3EVM defconfig Sanjeev Premi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080901201058.GE28999@flint.arm.linux.org.uk \
--to=linux@arm.linux.org.uk \
--cc=linux-omap@vger.kernel.org \
--cc=premi@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox