From: Felipe Balbi <me@felipebalbi.com>
To: "stanley.miao" <stanley.miao@windriver.com>
Cc: arun c <arun.edarath@gmail.com>,
"linux-omap@vger.kernel.org" <linux-omap@vger.kernel.org>
Subject: Re: [PATCH] ARM: OMAP3: Fix omapfb's problem on OMAP3430sdp
Date: Tue, 2 Sep 2008 11:14:32 +0300 [thread overview]
Message-ID: <20080902081429.GB6928@frodo> (raw)
In-Reply-To: <1220336007.19839.6.camel@localhost>
On Tue, Sep 02, 2008 at 02:13:27PM +0800, stanley.miao wrote:
> @@ -76,6 +81,11 @@ static int sdp2430_panel_enable(struct lcd_panel
> *panel)
> {
> u8 ded_val, ded_reg;
> u8 grp_val, grp_reg;
> +
> + if(is_sil_rev_greater_than(OMAP3430_REV_ES1_0)) {
missing space "if ()".
> @@ -104,6 +114,11 @@ static void sdp2430_panel_disable(struct lcd_panel
> *panel)
> {
> omap_set_gpio_dataout(enable_gpio, 0);
> omap_set_gpio_dataout(backlight_gpio, 0);
nothing to do with your patch, but these should be converted to
gpiolib.
> + if(is_sil_rev_greater_than(OMAP3430_REV_ES1_0)) {
missing space again. Please, run scripts/checkpatch.pl --strict patch.diff
before sending your patches so we avoid obvious style mistakes.
--
balbi
next prev parent reply other threads:[~2008-09-02 8:14 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-09-01 13:37 [PATCH] ARM: OMAP3: Fix omapfb's problem on OMAP3430sdp stanley.miao
2008-09-02 4:33 ` Gadiyar, Anand
2008-09-02 5:49 ` arun c
2008-09-02 6:13 ` stanley.miao
2008-09-02 8:14 ` Felipe Balbi [this message]
2008-09-02 9:33 ` stanley.miao
2008-09-05 17:13 ` Tony Lindgren
2008-09-08 2:27 ` stanley.miao
2008-09-02 14:51 ` David Brownell
2008-09-03 1:53 ` stanley.miao
2008-09-03 1:55 ` David Brownell
2008-09-03 3:40 ` stanley.miao
-- strict thread matches above, loose matches on Subject: below --
2008-09-08 2:42 stanley.miao
2008-09-08 3:29 ` stanley.miao
2008-09-10 17:46 ` Tony Lindgren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080902081429.GB6928@frodo \
--to=me@felipebalbi.com \
--cc=arun.edarath@gmail.com \
--cc=linux-omap@vger.kernel.org \
--cc=stanley.miao@windriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox