Re: [PATCH 0/2] twl4030-usb patches

[David Brownell <david-b@pacbell.net>]

On Tuesday 02 September 2008, Felipe Balbi wrote:
> 
> The following patches convert twl4030-usb to a platform_device
> in order to set the usb mode via platform_data and get
> rid of the Kconfig entry for that.

Shouldn't twl4030 first be converted to be a "new style"
I2C driver?  Then if this approach is to be used, its
probe() would create those platform devices as children
of the I2C device node, and with relevant platform_data.

The platform_data for all those child devices should be
provided as part of the platform_data for the "main" TWL
driver, so everything can be properly board-specific.

Also, since it seems twl4030 docs won't become public
but docs for its catalog versions[0] will, it'd be good
to update file headers and Kconfig to mention tps659x0
parts so that folk without twl4030 NDA's can eventually
work with this code...

- Dave


[0] http://focus.ti.com/docs/prod/folders/print/tps65950.html