From: David Brownell <david-b@pacbell.net>
To: me@felipebalbi.com
Cc: linux-omap@vger.kernel.org
Subject: Re: [patch 2.6.27-rc3-omap1] tweak musb_hdrc SOC init code
Date: Tue, 2 Sep 2008 12:54:33 -0700 [thread overview]
Message-ID: <200809021254.33265.david-b@pacbell.net> (raw)
In-Reply-To: <20080902193920.GE6814@frodo>
On Tuesday 02 September 2008, Felipe Balbi wrote:
>
> > Signed-off-by: David Brownell <dbrownell@users.sourceforge.net>
>
> Acked-by: Felipe Balbi <felipe.balbi@nokia.com>
>
> > +
> > + /* REVISIT charge pump on TWL4030 can supply up to
> > + * 100 mA ... but this value is board-specific, like
> > + * "mode", and should be passed to usb_musb_init().
> > + */
> > + .power = 50, /* up to 100 mA */
>
> We can add some parameters to usb_musb_init();
> Something similar should be done to hsmmc_init(), as of now it only
> registers one slot and some boards have more than one.
Let's wait till the twl4030 usb init gets some board-specific
parameterization. The MUSB init code should be called after
the TWL4030 is initialized, so it can use TWL facilities right
away.
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2008-09-02 19:54 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-09-02 19:05 [patch 2.6.27-rc3-omap1] tweak musb_hdrc SOC init code David Brownell
2008-09-02 19:39 ` Felipe Balbi
2008-09-02 19:54 ` David Brownell [this message]
2008-09-10 23:50 ` Tony Lindgren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200809021254.33265.david-b@pacbell.net \
--to=david-b@pacbell.net \
--cc=linux-omap@vger.kernel.org \
--cc=me@felipebalbi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox