From: David Brownell <david-b@pacbell.net>
To: Mark Brown <broonie@sirena.org.uk>, Steve Sakoman <sakoman@gmail.com>
Cc: linux-omap@vger.kernel.org, alsa-devel@alsa-project.org
Subject: Re: [alsa-devel] [PATCH 2/4] SOUND: SOC: CODECS: Add support for the TWL4030 audio codec
Date: Tue, 2 Sep 2008 13:38:53 -0700 [thread overview]
Message-ID: <200809021338.53965.david-b@pacbell.net> (raw)
In-Reply-To: <20080902185432.GA3553@sirena.org.uk>
On Tuesday 02 September 2008, Mark Brown wrote:
> On Tue, Sep 02, 2008 at 09:36:29AM -0700, Steve Sakoman wrote:
>
> > The chip allows 19.2 Mhz, 26 Mhz, or 38.4 Mhz input clocks to the
> > codec. All existing boards (Overo, Beagle, and OMAP3 EVM) use 26 Mhz
> > (generated by a fixed external oscillator chip). I'll check with the
> > Pandora folks, but I believe that they are also 26 Mhz.
>
> OK, a comment to that effect somewhere (perhaps in set_sysclk() which
> only accepts 26MHz) probably wouldn't go amiss. Someone working on a
> board where the hardware guys went for a different crystal will probably
> thank you for it some day :)
For that matter, as I've said on a separate thread, this board-specific
data can and should be set up as part of the TWL4030 initialization.
The paths by which boards can provide that data to the TWL4030 init
and thence to subsidiary device init (CODEC in this case) need to be
reworked before the TWL4030 code goes upstream. Being able to pass
the relevant clock rate shouldn't be too hard. :)
- Dave
p.s. As has come up in the context of Beagle, which is the most available
of those boards: the generally available version of TWL4030 will
have a different part number. Docs will be available for the catalog
parts, but they're not yet released:
http://focus.ti.com/docs/prod/folders/print/tps65950.html
next prev parent reply other threads:[~2008-09-02 20:45 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-09-01 21:57 [PATCH 0/4] ARM: OMAP2: Add support for Gumstix Overo sakoman
2008-09-01 21:57 ` [PATCH 1/4] ARM: OMAP2: Add support for the Gumstix Overo board sakoman
2008-09-01 21:57 ` [PATCH 2/4] SOUND: SOC: CODECS: Add support for the TWL4030 audio codec sakoman
2008-09-01 21:57 ` [PATCH 3/4] SOUND: SOC: OMAP: Add support for Gumstix Overo sakoman
2008-09-01 21:57 ` [PATCH 4/4] ARM: OMAP2: deconfig for the Gumstix Overo board sakoman
2008-09-02 11:29 ` [PATCH 3/4] SOUND: SOC: OMAP: Add support for Gumstix Overo Mark Brown
2008-09-02 13:19 ` Steve Sakoman
2008-09-02 11:26 ` [PATCH 2/4] SOUND: SOC: CODECS: Add support for the TWL4030 audio codec Mark Brown
2008-09-02 12:27 ` [alsa-devel] " Felipe Balbi
2008-09-02 14:25 ` Steve Sakoman
2008-09-02 14:53 ` Mark Brown
2008-09-02 16:36 ` Steve Sakoman
2008-09-02 18:54 ` [alsa-devel] " Mark Brown
2008-09-02 20:08 ` Liam Girdwood
2008-09-02 20:31 ` [alsa-devel] " Mark Brown
2008-09-02 20:51 ` Liam Girdwood
2008-09-02 20:48 ` [alsa-devel] " Steve Sakoman
2008-09-02 20:38 ` David Brownell [this message]
2008-09-02 0:46 ` [PATCH 1/4] ARM: OMAP2: Add support for the Gumstix Overo board Felipe Balbi
[not found] ` <200809020815.58792.david-b@pacbell.net>
2008-09-02 16:04 ` Steve Sakoman
2008-09-02 20:58 ` Russell King - ARM Linux
2008-09-02 21:06 ` Steve Sakoman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200809021338.53965.david-b@pacbell.net \
--to=david-b@pacbell.net \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@sirena.org.uk \
--cc=linux-omap@vger.kernel.org \
--cc=sakoman@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox