From: Mark Brown <broonie@sirena.org.uk>
To: Liam Girdwood <lrg@kernel.org>
Cc: Steve Sakoman <sakoman@gmail.com>,
alsa-devel@alsa-project.org, linux-omap@vger.kernel.org
Subject: Re: [alsa-devel] [PATCH 2/4] SOUND: SOC: CODECS: Add support for the TWL4030 audio codec
Date: Tue, 2 Sep 2008 21:31:21 +0100 [thread overview]
Message-ID: <20080902203120.GA20914@sirena.org.uk> (raw)
In-Reply-To: <1220386089.6499.223.camel@odin>
On Tue, Sep 02, 2008 at 09:08:09PM +0100, Liam Girdwood wrote:
> On Tue, 2008-09-02 at 19:54 +0100, Mark Brown wrote:
> > OK, a comment to that effect somewhere (perhaps in set_sysclk() which
> > only accepts 26MHz) probably wouldn't go amiss.
> The codec set_sysclk() should also accept 19.2MHz and 38.4MHz otherwise
> return -EINVAL. It should also have a nice comment too :)
Ideally, yes but it looked like that'd need additional code to set the
codec up to use them. Obviously the ideal thing would be if the driver
supports everything the chip does.
next prev parent reply other threads:[~2008-09-02 20:40 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-09-01 21:57 [PATCH 0/4] ARM: OMAP2: Add support for Gumstix Overo sakoman
2008-09-01 21:57 ` [PATCH 1/4] ARM: OMAP2: Add support for the Gumstix Overo board sakoman
2008-09-01 21:57 ` [PATCH 2/4] SOUND: SOC: CODECS: Add support for the TWL4030 audio codec sakoman
2008-09-01 21:57 ` [PATCH 3/4] SOUND: SOC: OMAP: Add support for Gumstix Overo sakoman
2008-09-01 21:57 ` [PATCH 4/4] ARM: OMAP2: deconfig for the Gumstix Overo board sakoman
2008-09-02 11:29 ` [PATCH 3/4] SOUND: SOC: OMAP: Add support for Gumstix Overo Mark Brown
2008-09-02 13:19 ` Steve Sakoman
2008-09-02 11:26 ` [PATCH 2/4] SOUND: SOC: CODECS: Add support for the TWL4030 audio codec Mark Brown
2008-09-02 12:27 ` [alsa-devel] " Felipe Balbi
2008-09-02 14:25 ` Steve Sakoman
2008-09-02 14:53 ` Mark Brown
2008-09-02 16:36 ` Steve Sakoman
2008-09-02 18:54 ` [alsa-devel] " Mark Brown
2008-09-02 20:08 ` Liam Girdwood
2008-09-02 20:31 ` Mark Brown [this message]
2008-09-02 20:51 ` Liam Girdwood
2008-09-02 20:48 ` [alsa-devel] " Steve Sakoman
2008-09-02 20:38 ` David Brownell
2008-09-02 0:46 ` [PATCH 1/4] ARM: OMAP2: Add support for the Gumstix Overo board Felipe Balbi
[not found] ` <200809020815.58792.david-b@pacbell.net>
2008-09-02 16:04 ` Steve Sakoman
2008-09-02 20:58 ` Russell King - ARM Linux
2008-09-02 21:06 ` Steve Sakoman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080902203120.GA20914@sirena.org.uk \
--to=broonie@sirena.org.uk \
--cc=alsa-devel@alsa-project.org \
--cc=linux-omap@vger.kernel.org \
--cc=lrg@kernel.org \
--cc=sakoman@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox