* [RFC: 2.6 patch] fix arch/arm/plat-omap/gpio.c compilation
@ 2008-08-29 9:23 Adrian Bunk
2008-09-02 22:48 ` Tony Lindgren
0 siblings, 1 reply; 2+ messages in thread
From: Adrian Bunk @ 2008-08-29 9:23 UTC (permalink / raw)
To: Russell King; +Cc: linux-arm-kernel, linux-omap
This patch fixes the following compile error:
<-- snip -->
...
CC arch/arm/plat-omap/gpio.o
...
arch/arm/plat-omap/gpio.c: In function '_omap_gpio_init':
arch/arm/plat-omap/gpio.c:1492: error: 'omap_mpuio_device' undeclared (first use in this function)
arch/arm/plat-omap/gpio.c:1492: error: (Each undeclared identifier is reported only once
arch/arm/plat-omap/gpio.c:1492: error: for each function it appears in.)
make[2]: *** [arch/arm/plat-omap/gpio.o] Error 1
<-- snip -->
Reported-by: Adrian Bunk <bunk@kernel.org>
Signed-off-by: Adrian Bunk <bunk@kernel.org>
---
diff --git a/arch/arm/plat-omap/gpio.c b/arch/arm/plat-omap/gpio.c
index 3e76ee2..9e1341e 100644
--- a/arch/arm/plat-omap/gpio.c
+++ b/arch/arm/plat-omap/gpio.c
@@ -1488,7 +1488,7 @@ static int __init _omap_gpio_init(void)
bank->chip.set = gpio_set;
if (bank_is_mpuio(bank)) {
bank->chip.label = "mpuio";
-#ifdef CONFIG_ARCH_OMAP1
+#ifdef CONFIG_ARCH_OMAP16XX
bank->chip.dev = &omap_mpuio_device.dev;
#endif
bank->chip.base = OMAP_MPUIO(0);
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [RFC: 2.6 patch] fix arch/arm/plat-omap/gpio.c compilation
2008-08-29 9:23 [RFC: 2.6 patch] fix arch/arm/plat-omap/gpio.c compilation Adrian Bunk
@ 2008-09-02 22:48 ` Tony Lindgren
0 siblings, 0 replies; 2+ messages in thread
From: Tony Lindgren @ 2008-09-02 22:48 UTC (permalink / raw)
To: Adrian Bunk; +Cc: Russell King, linux-arm-kernel, linux-omap
* Adrian Bunk <bunk@kernel.org> [080829 02:24]:
> This patch fixes the following compile error:
>
> <-- snip -->
>
> ...
> CC arch/arm/plat-omap/gpio.o
> ...
> arch/arm/plat-omap/gpio.c: In function '_omap_gpio_init':
> arch/arm/plat-omap/gpio.c:1492: error: 'omap_mpuio_device' undeclared (first use in this function)
> arch/arm/plat-omap/gpio.c:1492: error: (Each undeclared identifier is reported only once
> arch/arm/plat-omap/gpio.c:1492: error: for each function it appears in.)
> make[2]: *** [arch/arm/plat-omap/gpio.o] Error 1
>
> <-- snip -->
>
> Reported-by: Adrian Bunk <bunk@kernel.org>
> Signed-off-by: Adrian Bunk <bunk@kernel.org>
>
> ---
>
> diff --git a/arch/arm/plat-omap/gpio.c b/arch/arm/plat-omap/gpio.c
> index 3e76ee2..9e1341e 100644
> --- a/arch/arm/plat-omap/gpio.c
> +++ b/arch/arm/plat-omap/gpio.c
> @@ -1488,7 +1488,7 @@ static int __init _omap_gpio_init(void)
> bank->chip.set = gpio_set;
> if (bank_is_mpuio(bank)) {
> bank->chip.label = "mpuio";
> -#ifdef CONFIG_ARCH_OMAP1
> +#ifdef CONFIG_ARCH_OMAP16XX
> bank->chip.dev = &omap_mpuio_device.dev;
> #endif
> bank->chip.base = OMAP_MPUIO(0);
>
Looks like a proper fix. BTW, this same fix is already in a patch from
Russell.
Tony
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2008-09-02 22:48 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-08-29 9:23 [RFC: 2.6 patch] fix arch/arm/plat-omap/gpio.c compilation Adrian Bunk
2008-09-02 22:48 ` Tony Lindgren
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox