Re: [PATCH] ARM: OMAP3: Fix omapfb's problem on OMAP3430sdp

[Tony Lindgren <tony@atomide.com>]

* stanley.miao <stanley.miao@windriver.com> [080902 02:32]:
> Thanks. I resolved the style problem. If gpio function needs to be
> changed, I think it should be in a single patch.
> 
> Re-send the patch again.
> 
> Fix omapfb's problem on OMAP3430
> 
> Signed-off-by: Stanley.Miao <stanley.miao@windriver.com>
> ---
>  drivers/video/omap/lcd_2430sdp.c |   17 +++++++++++++++++
>  1 files changed, 17 insertions(+), 0 deletions(-)
> 
> diff --git a/drivers/video/omap/lcd_2430sdp.c
> b/drivers/video/omap/lcd_2430sdp.c
> index 9af6cd0..cf8d2a5 100644
> --- a/drivers/video/omap/lcd_2430sdp.c
> +++ b/drivers/video/omap/lcd_2430sdp.c
> @@ -23,6 +23,7 @@
>  
>  #include <linux/module.h>
>  #include <linux/platform_device.h>
> +#include <linux/delay.h>
>  #include <linux/i2c/twl4030.h>
>  
>  #include <mach/gpio.h>
> @@ -45,6 +46,10 @@ static unsigned enable_gpio;
>  #define ENABLE_VAUX3_DEDICATED	0x03
>  #define ENABLE_VAUX3_DEV_GRP	0x20
>  
> +#define ENABLE_VPLL2_DEDICATED          0x05
> +#define ENABLE_VPLL2_DEV_GRP            0xE0
> +#define TWL4030_VPLL2_DEV_GRP           0x33
> +#define TWL4030_VPLL2_DEDICATED         0x36
>  
>  #define t2_out(c, r, v) twl4030_i2c_write_u8(c, r, v)
>  
> @@ -77,6 +82,13 @@ static int sdp2430_panel_enable(struct lcd_panel
> *panel)
>  	u8 ded_val, ded_reg;
>  	u8 grp_val, grp_reg;
>  
> +	if (is_sil_rev_greater_than(OMAP3430_REV_ES1_0)) {
> +		t2_out(PM_RECEIVER, ENABLE_VPLL2_DEDICATED,
> +					TWL4030_VPLL2_DEDICATED);
> +		t2_out(PM_RECEIVER, ENABLE_VPLL2_DEV_GRP,
> +					TWL4030_VPLL2_DEV_GRP);
> +	}
> +
>  	if (machine_is_omap_3430sdp()) {
>  		ded_reg = TWL4030_VAUX3_DEDICATED;
>  		ded_val = ENABLE_VAUX3_DEDICATED;

How about putting the is_sel_rev_greater_than test within the
machine_is_omap3430sdp test?

Tony

> @@ -104,6 +116,11 @@ static void sdp2430_panel_disable(struct lcd_panel
> *panel)
>  {
>  	omap_set_gpio_dataout(enable_gpio, 0);
>  	omap_set_gpio_dataout(backlight_gpio, 0);
> +	if (is_sil_rev_greater_than(OMAP3430_REV_ES1_0)) {
> +		t2_out(PM_RECEIVER, 0x0, TWL4030_VPLL2_DEDICATED);
> +		t2_out(PM_RECEIVER, 0x0, TWL4030_VPLL2_DEV_GRP);
> +		mdelay(4);
> +	}
>  }
>  
>  static unsigned long sdp2430_panel_get_caps(struct lcd_panel *panel)
> -- 
> 1.5.6.3
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-omap" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html