From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tony Lindgren Subject: Re: [PATCH 22/33] add omap nand drivers Date: Fri, 5 Sep 2008 11:07:24 -0700 Message-ID: <20080905180723.GQ24202@atomide.com> References: <1220116593-862-1-git-send-email-me@felipebalbi.com> <1220116593-862-22-git-send-email-me@felipebalbi.com> <1220116593-862-23-git-send-email-me@felipebalbi.com> <200808311408.18492.david-b@pacbell.net> <20080831212842.GF9887@frodo> Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: Received: from mho-01-bos.mailhop.org ([63.208.196.178]:61554 "EHLO mho-01-bos.mailhop.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751774AbYIESH3 (ORCPT ); Fri, 5 Sep 2008 14:07:29 -0400 Content-Disposition: inline In-Reply-To: <20080831212842.GF9887@frodo> Sender: linux-omap-owner@vger.kernel.org List-Id: linux-omap@vger.kernel.org To: Felipe Balbi Cc: David Brownell , linux-omap@vger.kernel.org, Felipe Balbi * Felipe Balbi [080831 14:29]: > On Sun, Aug 31, 2008 at 02:08:18PM -0700, David Brownell wrote: > > Hmm, this seems like three distinct drivers to me. > > Which should mean three separate patches ... going > > go the MTD list! > >=20 > >=20 > > On Saturday 30 August 2008, Felipe Balbi wrote: > > >=20 > > > +config MTD_NAND_OMAP2 > > > +=A0=A0=A0=A0=A0=A0=A0tristate "NAND Flash device on OMAP2 and OM= AP3" > > > +=A0=A0=A0=A0=A0=A0=A0depends on ARM && MTD_NAND && (ARCH_OMAP2 |= | ARCH_OMAP3) > > > +=A0=A0=A0=A0=A0=A0=A0help > > > + =A0 =A0 =A0 =A0 =A0Support for NAND flash on Texas Instruments = OMAP2 and OMAP3 platforms. > >=20 > > I've got a small patch for this one which I'll post. >=20 > Great, I can meld it on the final version of the driver. Thanks >=20 > > > +config MTD_NAND_OMAP > > > +=A0=A0=A0=A0=A0=A0=A0tristate "NAND Flash device on OMAP H3/H2/P= 2 boards" > > > +=A0=A0=A0=A0=A0=A0=A0depends on ARM && ARCH_OMAP1 && MTD_NAND &&= (MACH_OMAP_H2 || MACH_OMAP_H3 || MACH_OMAP_PERSEUS2) > > > +=A0=A0=A0=A0=A0=A0=A0help > > > +=A0=A0=A0=A0=A0=A0=A0 =A0Support for NAND flash on Texas Instrum= ents H3/H2/P2 platforms. > > > + > > > +config MTD_NAND_OMAP_HW > > > +=A0=A0=A0=A0=A0=A0=A0bool "OMAP HW NAND Flash controller support= " > > > + =A0 =A0 =A0 =A0depends on ARM && ARCH_OMAP16XX && MTD_NAND > > > + > > > +=A0=A0=A0=A0=A0=A0=A0help > > > +=A0=A0=A0=A0=A0=A0=A0 =A0Driver for TI OMAP16xx hardware NAND fl= ash controller. > >=20 > > This one raises the question: why are there *TWO* drivers for > > the same hardware? Which one is the failed experiment? >=20 > It's even worse. If you look at the Makefile itself, there are three: >=20 > obj-$(CONFIG_MTD_NAND_OMAP) +=3D omap-nand-flash.o > obj-$(CONFIG_MTD_NAND_OMAP2) +=3D omap2.o > obj-$(CONFIG_MTD_NAND_OMAP_HW) +=3D omap-hw.o >=20 > Looks like this series was good for finding some weird stuff on > linux-omap ;-) Then there's also the MTD_NAND_TOTO.. Sure there were various NAND controllers, but if some of them are no longer maintained, we should just export them into patches and remove from kernel. Tony -- To unsubscribe from this list: send the line "unsubscribe linux-omap" i= n the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html