Re: [PATCH] MUSB: Set INDEX register to 0 before accessing CONFIGDATA

[David Brownell <david-b-yBeKhBN/0LDR7s880joybQ@public.gmane.org>]

On Thursday 04 September 2008, Gadiyar, Anand wrote:
> From: Anand Gadiyar <gadiyar-l0cyMroinI0@public.gmane.org>
> 
> The Index register needs to be zero to access CONFIGDATA.
> musb_ep_select()will not set the MUSB_INDEX register unless INDEXED
> mode addressing is used. This change will set the register correctly
> in INDEXED as well as FLAT mode.
> 
> Signed-off-by: Anand Gadiyar <gadiyar-l0cyMroinI0@public.gmane.org>
> CC: Ajay Kumar Gupta <ajay.gupta-l0cyMroinI0@public.gmane.org>

ACK.  I *know* it was originally written that way.  I think
the change was one of the Blackfin patches ... I hope this
isn't one of those cases where the Blackfin version of this
core acts differently.  (Like clearing that DMA IRQ status...)


> ---
> diff --git a/drivers/usb/musb/musb_core.c b/drivers/usb/musb/musb_core.c
> index b398776..6c4da2f 100644
> --- a/drivers/usb/musb/musb_core.c
> +++ b/drivers/usb/musb/musb_core.c
> @@ -1334,7 +1334,7 @@ static int __init musb_core_init(u16 musb_type, struct musb *musb)
>  	int		i;
>  
>  	/* log core options (read using indexed model) */
> -	musb_ep_select(mbase, 0);
> +	musb_writeb(mbase, MUSB_INDEX, 0);
>  	reg = musb_readb(mbase, 0x10 + MUSB_CONFIGDATA);
>  
>  	strcpy(aInfo, (reg & MUSB_CONFIGDATA_UTMIDW) ? "UTMI-16" : "UTMI-8");--
> To unsubscribe from this list: send the line "unsubscribe linux-usb" in
> the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 


--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html