Re: musb broken, was [RFC 0/2] McBSP and ASoC OMAP update patches for 2430 and 34xx

Re: musb broken, was [RFC 0/2] McBSP and ASoC OMAP update patches for 2430 and 34xx

[Steve Sakoman]

On Fri, Sep 5, 2008 at 10:52 AM, Tony Lindgren <tony@atomide.com> wrote:
> * Steve Sakoman <sakoman@gmail.com> [080905 10:24]:
>> > Hmm, is the musb broken now?
>>
>> It is on Overo if I base my patches against current top of tree
>> (a376251519ced5831ed07ed234430725230ed93a)
>>
>> Doesn't crash, just quietly doesn't work.  I hear from Beagle folk
>> that musb doesn't work there either.   I have it configured as a host
>> port, and IIRC so do the Beagle folks
>>
>> If I base my patches against the state of the tree just prior to the
>> move to rc5 (81c893795c2e1fbe0bf5f638ed6ae1e500b80a2d), musb works as
>> well as it ever has.
>
> Well with -rc5 we switched to the drivers/usb/musb code from mainline
> kernel. Maybe try to diff musb code with:
>
> $ git-diff 81c893795c2e1fbe0bf5f638ed6ae1e500b80a2d.. drivers/usb/musb
>
> And see if there are any clues?

I did that and found that there are very few changes of substance,
mostly formatting and comments.  In fact there were only a few lines
that looked promising at all.

Mans Rullgard has verified that restoring these few lines fixes the
musb issue on beagle (using musb in gadget mode) and I have verified
that it fixes the issue on Overo (which uses musb in host mode).

Mans has a patch in his git:

http://git.mansr.com/?p=linux-omap;a=commitdiff;h=1e5bc41773bb981b3a89bd762becf98c72be5e4c

Neither of us understand musb details enough to propose this as *the*
fix, but it seems likely to be the issue.

Steve

Re: musb broken, was [RFC 0/2] McBSP and ASoC OMAP update patches for 2430 and 34xx

[David Brownell]

On Saturday 06 September 2008, Steve Sakoman wrote:
> On Fri, Sep 5, 2008 at 10:52 AM, Tony Lindgren <tony@atomide.com> wrote:
> > * Steve Sakoman <sakoman@gmail.com> [080905 10:24]:
> >> > Hmm, is the musb broken now?
> >>
> >> It is on Overo if I base my patches against current top of tree
> >> (a376251519ced5831ed07ed234430725230ed93a)
> >>
> >> Doesn't crash, just quietly doesn't work.  I hear from Beagle folk
> >> that musb doesn't work there either.  ...

A while back I tried a patch making the rc3-omap code match mainline
(more or less) on Beagle, and it failed ... so I've been tracking
down various RC3 issues.

I don't have all of them yet, but various "used to work" (on DaVinci
and TUSB6010) scenarios -- plugging/unplugging the B side of a cable
(Beagle == host), reboot with cable connected (Beagle == peripheral)
are being trouble.

There's also a notification issue with CDC Ethernet ... if the usb0
interface (Beagle == peripheral) is brought up before the host gets
connected, the host can't talk to it.  I just sent that patch in:

  http://marc.info/?l=linux-usb&m=122076214105934&w=2

 
> Mans has a patch in his git:
> 
> http://git.mansr.com/?p=linux-omap;a=commitdiff;h=1e5bc41773bb981b3a89bd762becf98c72be5e4c
> 
> Neither of us understand musb details enough to propose this as *the*
> fix, but it seems likely to be the issue.

Missing that should probably make trouble, yes.

Re: musb broken, was [RFC 0/2] McBSP and ASoC OMAP update patches for 2430 and 34xx

[Måns Rullgård]

David Brownell <david-b@pacbell.net> writes:

> On Saturday 06 September 2008, Steve Sakoman wrote:
>> On Fri, Sep 5, 2008 at 10:52 AM, Tony Lindgren <tony@atomide.com> wrote:
>> > * Steve Sakoman <sakoman@gmail.com> [080905 10:24]:
>> >> > Hmm, is the musb broken now?
>> >>
>> >> It is on Overo if I base my patches against current top of tree
>> >> (a376251519ced5831ed07ed234430725230ed93a)
>> >>
>> >> Doesn't crash, just quietly doesn't work.  I hear from Beagle folk
>> >> that musb doesn't work there either.  ...
>
> A while back I tried a patch making the rc3-omap code match mainline
> (more or less) on Beagle, and it failed ... so I've been tracking
> down various RC3 issues.
>
> I don't have all of them yet, but various "used to work" (on DaVinci
> and TUSB6010) scenarios -- plugging/unplugging the B side of a cable
> (Beagle == host), reboot with cable connected (Beagle == peripheral)
> are being trouble.
>
> There's also a notification issue with CDC Ethernet ... if the usb0
> interface (Beagle == peripheral) is brought up before the host gets
> connected, the host can't talk to it.  I just sent that patch in:
>
>   http://marc.info/?l=linux-usb&m=122076214105934&w=2

That explains what I've been seeing.  I've applied it to my tree, but
not tested yet.

>> Mans has a patch in his git:
>> 
>> http://git.mansr.com/?p=linux-omap;a=commitdiff;h=1e5bc41773bb981b3a89bd762becf98c72be5e4c
>> 
>> Neither of us understand musb details enough to propose this as *the*
>> fix, but it seems likely to be the issue.
>
> Missing that should probably make trouble, yes.

I've also had to revert the "usb: musb: pass configuration specifics
via pdata" commits:

  ffd60d49c70b31d26430a1098edf0eef5e4dfac8 in linux-omap
  ca6d1b1333bc2e61e37982de1f28d8604c232414 in mainline

I suspect there are simply some tables missing for the Beagle board,
but I haven't a clue what should go in them.

-- 
Måns Rullgård
mans@mansr.com

--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: musb broken, was [RFC 0/2] McBSP and ASoC OMAP update patches for 2430 and 34xx

[David Brownell]

On Sunday 07 September 2008, Måns Rullgård wrote:
> I've also had to revert the "usb: musb: pass configuration specifics
> via pdata" commits:
> 
>   ffd60d49c70b31d26430a1098edf0eef5e4dfac8 in linux-omap
>   ca6d1b1333bc2e61e37982de1f28d8604c232414 in mainline
> 
> I suspect there are simply some tables missing for the Beagle board,
> but I haven't a clue what should go in them.

Odd, that's in the RC3 code and it works for me.

I did need some tweaks to improve fault recovery though,
one of which I've posted (but it's not yet been merged):

  http://marc.info/?l=linux-omap&m=122038390701430&w=2

Another patch is more diagnostic-oriented, and doesn't
change any behaviors.

- Dave
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: musb broken, was [RFC 0/2] McBSP and ASoC OMAP update patches for 2430 and 34xx

[Steve Sakoman]

On Sun, Sep 7, 2008 at 10:37 AM, David Brownell <david-b@pacbell.net> wrote:
> On Sunday 07 September 2008, Måns Rullgård wrote:
>> I've also had to revert the "usb: musb: pass configuration specifics
>> via pdata" commits:
>>
>>   ffd60d49c70b31d26430a1098edf0eef5e4dfac8 in linux-omap
>>   ca6d1b1333bc2e61e37982de1f28d8604c232414 in mainline
>>
>> I suspect there are simply some tables missing for the Beagle board,
>> but I haven't a clue what should go in them.
>
> Odd, that's in the RC3 code and it works for me.

I don't need to revert those commits on Overo and it works "as well as
it ever has" which means that I get disconnects/reconnects of all
devices at random intervals.  I am using musb in host mode, whereas I
think Mans is in device/gadget mode.

Steve
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: musb broken, was [RFC 0/2] McBSP and ASoC OMAP update patches for 2430 and 34xx

[Måns Rullgård]

"Steve Sakoman" <sakoman@gmail.com> writes:

> On Sun, Sep 7, 2008 at 10:37 AM, David Brownell <david-b@pacbell.net> wrote:
>> On Sunday 07 September 2008, Måns Rullgård wrote:
>>> I've also had to revert the "usb: musb: pass configuration specifics
>>> via pdata" commits:
>>>
>>>   ffd60d49c70b31d26430a1098edf0eef5e4dfac8 in linux-omap
>>>   ca6d1b1333bc2e61e37982de1f28d8604c232414 in mainline
>>>
>>> I suspect there are simply some tables missing for the Beagle board,
>>> but I haven't a clue what should go in them.
>>
>> Odd, that's in the RC3 code and it works for me.
>
> I don't need to revert those commits on Overo and it works "as well as
> it ever has" which means that I get disconnects/reconnects of all
> devices at random intervals.  I am using musb in host mode, whereas I
> think Mans is in device/gadget mode.

Maybe it started working again.  I know for sure it broke gadget mode
on the Beagle when it first hit linux-omap, and I haven't tried it
since.  Perhaps I should give it another go.

-- 
Måns Rullgård
mans@mansr.com
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html