Re: [PATCH 32/33] add omap 1-wire interface driver

[Russell King - ARM Linux <linux@arm.linux.org.uk>]

On Mon, Sep 08, 2008 at 11:05:21AM -0700, Tony Lindgren wrote:
> * Madhusudhan Chikkature <madhu.cr@ti.com> [080908 05:15]:
> > 
> > ----- Original Message ----- 
> > From: "Tony Lindgren" <tony@atomide.com>
> > To: "Madhusudhan Chikkature" <madhu.cr@ti.com>
> > Cc: "Felipe Balbi" <me@felipebalbi.com>; <linux-omap@vger.kernel.org>; "Felipe Balbi" <felipe.balbi@nokia.com>
> > Sent: Friday, September 05, 2008 11:29 PM
> > Subject: Re: [PATCH 32/33] add omap 1-wire interface driver
> > 
> > 
> > >* Madhusudhan Chikkature <madhu.cr@ti.com> [080901 06:16]:
> > >> Hi,
> > >> 
> > >> The HDQ patchset that I posted to Tony were given ACK by Evgeniy Polyakov on the omap list. I hope that helps.
> > > 
> > > Madhu, can you post your 1-wire driver to LKML and Cc Evgeniy Polyakov
> > > so we can get that integrated? Also Cc l-o list.
> > I have a question regarding this. In fact it can be a generic question which might apply for other drivers as well. How do we post the OMAP3 related driver patches to LKML or any other driver specific lists if OMAP3 base support is not already  present there?
> 
> Well the drivers should not have dependencies to omap3 headers.
> And hopefully we'll have the minimal omap3 support integrated when
> 2.6.28 opens.
> 
> Also, you're already getting IORESOURCE_MEM as rerource. And isn't
> this driver also on 24XX chips too?
> 
> BTW, how about change it to use __raw_read/write instead of
> omap_read/write? Just ioremap the IORESOURCE_MEM, see
> the recent ioremap changes.

Last point - shouldn't it be converted to using mutexes instead of
semaphores?