From: Tony Lindgren <tony@atomide.com>
To: Russell King - ARM Linux <linux@arm.linux.org.uk>
Cc: linux-omap@vger.kernel.org
Subject: Re: Changes which shouldn't be in OMAP tree
Date: Tue, 9 Sep 2008 08:25:44 -0700 [thread overview]
Message-ID: <20080909152543.GN29054@atomide.com> (raw)
In-Reply-To: <20080909081213.GD9104@flint.arm.linux.org.uk>
* Russell King - ARM Linux <linux@arm.linux.org.uk> [080909 01:12]:
> Tony (and whoever looks after the omapzoom tree),
>
> While reviewing the omapzoom tree, I came across these three changes.
> They all shouldn't be there - I think they're all merge errors.
>
> The last one was fixed by a patch which added line 272 with the comment
> "relocate the stack".
>
> Please take a look and revert these.
Thanks, reverted in l-o tree.
Tony
>
> diff --git a/arch/arm/boot/.gitignore b/arch/arm/boot/.gitignore
> index ce1c5ff..bbe9905 100644
> --- a/arch/arm/boot/.gitignore
> +++ b/arch/arm/boot/.gitignore
> @@ -1,5 +1,5 @@
> Image
> zImage
> +uImage
> xipImage
> bootpImage
> -uImage
> diff --git a/arch/arm/boot/compressed/head.S b/arch/arm/boot/compressed/head.S
> index 3c2c8f2..32be061 100644
> --- a/arch/arm/boot/compressed/head.S
> +++ b/arch/arm/boot/compressed/head.S
> @@ -55,7 +55,7 @@
> #elif defined(CONFIG_ARCH_S3C2410)
> .macro loadsp, rb
> mov \rb, #0x50000000
> - add \rb, \rb, #0x4000 * CONFIG_S3C_LOWLEVEL_UART_PORT
> + add \rb, \rb, #0x4000 * CONFIG_S3C2410_LOWLEVEL_UART_PORT
> .endm
> #else
> .macro loadsp, rb
> @@ -782,6 +782,7 @@ __armv7_mmu_cache_flush:
> mcr p15, 0, r10, c7, c14, 0 @ clean+invalidate D
> b iflush
> hierarchical:
> + adr sp, no_cache_id @ non-v7 code is temp stack
> stmfd sp!, {r0-r5, r7, r9-r11}
> mrc p15, 1, r0, c0, c0, 1 @ read clidr
> ands r3, r0, #0x7000000 @ extract loc from clidr
>
prev parent reply other threads:[~2008-09-09 15:25 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-09-09 8:12 Changes which shouldn't be in OMAP tree Russell King - ARM Linux
2008-09-09 15:25 ` Tony Lindgren [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080909152543.GN29054@atomide.com \
--to=tony@atomide.com \
--cc=linux-omap@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox