From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tony Lindgren Subject: Re: Bug in twl4030backupbatt_voltage() Date: Wed, 10 Sep 2008 08:39:46 -0700 Message-ID: <20080910153946.GA29054@atomide.com> References: <48BEA8DC.3030905@nokia.com> <20080909174214.GP29054@atomide.com> <48C7771E.6080307@nokia.com> <022001c91346$d09d54a0$LocalHost@wipultra1303> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from mho-01-bos.mailhop.org ([63.208.196.178]:57386 "EHLO mho-01-bos.mailhop.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752216AbYIJPj4 (ORCPT ); Wed, 10 Sep 2008 11:39:56 -0400 Content-Disposition: inline In-Reply-To: <022001c91346$d09d54a0$LocalHost@wipultra1303> Sender: linux-omap-owner@vger.kernel.org List-Id: linux-omap@vger.kernel.org To: Madhusudhan Chikkature Cc: Adrian Hunter , linux-omap@vger.kernel.org * Madhusudhan Chikkature [080910 06:12]: > > ----- Original Message ----- > From: "Adrian Hunter" > To: "Tony Lindgren" > Cc: ; > Sent: Wednesday, September 10, 2008 12:58 PM > Subject: Re: Bug in twl4030backupbatt_voltage() > > > > Tony Lindgren wrote: > >> * Adrian Hunter [080903 08:08]: > >>> In the omap tree, commit f91fd98be045bec9c18e13110f22dafd44cb84b5 > >>> fixed a bug with the use of function twl4030_madc_conversion() > >>> relating to the local variable 'struct twl4030_madc_request req' > >>> not being fully initialised. > >>> > >>> The same problem appears to be in the function > >>> twl4030backupbatt_voltage() which is in drivers/power/twl4030_bci_battery.c > >> > >> Thanks, I'll initialize it to NULL. Wouldn't it have been easier just > >> to write a patch instead of the description above? :) > > > > Apparently. > > > > There is also req.do_avg which should be zero, if you assume the programmer's > > intent was to have uninitialised members set to zero. > I guess, I did not look at all the other members of the "twl4030_madc_request" structure. I might have missed it. > The do_avg and func_cb fields can both be set to NULL. Can you please check the code and send a patch? Thanks, Tony