[PATCH 2/3][OMAP 3/4]table end for wcd command definitions

[PATCH 2/3][OMAP 3/4]table end for wcd command definitions

[Ramirez Luna, Omar]

Added the table end 'CMD_BASE_END_OFFSET' define in wcdioctl.h

Signed-off-by: Omar Ramirez Luna <x00omar@ti.com>
---

Index: omapkernel/arch/arm/plat-omap/include/mach/bridge/wcdioctl.h
===================================================================
--- omapkernel.orig/arch/arm/plat-omap/include/mach/bridge/wcdioctl.h	2008-08-22 19:03:10.000000000 -0500
+++ omapkernel/arch/arm/plat-omap/include/mach/bridge/wcdioctl.h	2008-08-22 19:20:05.000000000 -0500
@@ -515,4 +515,5 @@
 #define CMD_CMM_GETINFO_OFFSET	  (CMD_CMM_BASE_OFFSET + 3)
 #define CMD_CMM_END_OFFSET	      CMD_CMM_GETINFO_OFFSET
 
+#define CMD_BASE_END_OFFSET	CMD_CMM_END_OFFSET
 #endif				/* WCDIOCTL_ */

Re: [PATCH 2/3][OMAP 3/4]table end for wcd command definitions

[Hiroshi DOYU]

Hi Omar,

I just noticed that the bridge specific header files are located
under "linux/arch/arm/plat-omap/include/mach/bridge/", but it may be
better to have them under "arch/arm/plat-omap/include/bridge/" because
those header files are not related to the omap archtecture so much and
mostly used for bridge specific purpose, although omap is the only
platform to have bridge with dsp;) For me, it would make more sense
logically, and also practically grepp'ing would work more nicely
without any fancy tools like specifiying the directories to search.

Any comments?

	Hiroshi DOYU

From: "ext Ramirez Luna, Omar" <x00omar@ti.com>
Subject: [PATCH 2/3][OMAP 3/4]table end for wcd command definitions
Date: Thu, 28 Aug 2008 20:30:44 -0500

> Added the table end 'CMD_BASE_END_OFFSET' define in wcdioctl.h
> 
> Signed-off-by: Omar Ramirez Luna <x00omar@ti.com>
> ---
> 
> Index: omapkernel/arch/arm/plat-omap/include/mach/bridge/wcdioctl.h
> ===================================================================
> --- omapkernel.orig/arch/arm/plat-omap/include/mach/bridge/wcdioctl.h	2008-08-22 19:03:10.000000000 -0500
> +++ omapkernel/arch/arm/plat-omap/include/mach/bridge/wcdioctl.h	2008-08-22 19:20:05.000000000 -0500
> @@ -515,4 +515,5 @@
>  #define CMD_CMM_GETINFO_OFFSET	  (CMD_CMM_BASE_OFFSET + 3)
>  #define CMD_CMM_END_OFFSET	      CMD_CMM_GETINFO_OFFSET
>  
> +#define CMD_BASE_END_OFFSET	CMD_CMM_END_OFFSET
>  #endif				/* WCDIOCTL_ */
> --
> To unsubscribe from this list: send the line "unsubscribe linux-omap" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH 2/3][OMAP 3/4]table end for wcd command definitions

[Hiroshi DOYU]

Hi,

Although this TI bridge patches are not integrated and a bit
independent S/W component, it would be nice to get some comments just
on this bridge header file location from kernel maintainer's
perspective.

"arch/arm/plat-omap/include/mach/bridge"
  or "arch/arm/plat-omap/include/bridge"?

	 Hiroshi DOYU

From: Hiroshi DOYU <Hiroshi.DOYU@nokia.com>
Subject: Re: [PATCH 2/3][OMAP 3/4]table end for wcd command definitions
Date: Fri, 29 Aug 2008 08:03:13 +0300 (EEST)

> Hi Omar,
> 
> I just noticed that the bridge specific header files are located
> under "linux/arch/arm/plat-omap/include/mach/bridge/", but it may be
> better to have them under "arch/arm/plat-omap/include/bridge/" because
> those header files are not related to the omap archtecture so much and
> mostly used for bridge specific purpose, although omap is the only
> platform to have bridge with dsp;) For me, it would make more sense
> logically, and also practically grepp'ing would work more nicely
> without any fancy tools like specifiying the directories to search.
> 
> Any comments?
> 
> 	Hiroshi DOYU
> 
> From: "ext Ramirez Luna, Omar" <x00omar@ti.com>
> Subject: [PATCH 2/3][OMAP 3/4]table end for wcd command definitions
> Date: Thu, 28 Aug 2008 20:30:44 -0500
> 
> > Added the table end 'CMD_BASE_END_OFFSET' define in wcdioctl.h
> > 
> > Signed-off-by: Omar Ramirez Luna <x00omar@ti.com>
> > ---
> > 
> > Index: omapkernel/arch/arm/plat-omap/include/mach/bridge/wcdioctl.h
> > ===================================================================
> > --- omapkernel.orig/arch/arm/plat-omap/include/mach/bridge/wcdioctl.h	2008-08-22 19:03:10.000000000 -0500
> > +++ omapkernel/arch/arm/plat-omap/include/mach/bridge/wcdioctl.h	2008-08-22 19:20:05.000000000 -0500
> > @@ -515,4 +515,5 @@
> >  #define CMD_CMM_GETINFO_OFFSET	  (CMD_CMM_BASE_OFFSET + 3)
> >  #define CMD_CMM_END_OFFSET	      CMD_CMM_GETINFO_OFFSET
> >  
> > +#define CMD_BASE_END_OFFSET	CMD_CMM_END_OFFSET
> >  #endif				/* WCDIOCTL_ */
> > --
> > To unsubscribe from this list: send the line "unsubscribe linux-omap" in
> > the body of a message to majordomo@vger.kernel.org
> > More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH 2/3][OMAP 3/4]table end for wcd command definitions

[Tony Lindgren]

* Hiroshi DOYU <Hiroshi.DOYU@nokia.com> [080909 21:08]:
> Hi,
> 
> Although this TI bridge patches are not integrated and a bit
> independent S/W component, it would be nice to get some comments just
> on this bridge header file location from kernel maintainer's
> perspective.
> 
> "arch/arm/plat-omap/include/mach/bridge"
>   or "arch/arm/plat-omap/include/bridge"?

How about put the bridge specific headers under include/linux/dspbridge?
Then you can have just the omap specific headers under
arch/arm/plat-omap/include/mach.

Tony


> 
> 	 Hiroshi DOYU
> 
> From: Hiroshi DOYU <Hiroshi.DOYU@nokia.com>
> Subject: Re: [PATCH 2/3][OMAP 3/4]table end for wcd command definitions
> Date: Fri, 29 Aug 2008 08:03:13 +0300 (EEST)
> 
> > Hi Omar,
> > 
> > I just noticed that the bridge specific header files are located
> > under "linux/arch/arm/plat-omap/include/mach/bridge/", but it may be
> > better to have them under "arch/arm/plat-omap/include/bridge/" because
> > those header files are not related to the omap archtecture so much and
> > mostly used for bridge specific purpose, although omap is the only
> > platform to have bridge with dsp;) For me, it would make more sense
> > logically, and also practically grepp'ing would work more nicely
> > without any fancy tools like specifiying the directories to search.
> > 
> > Any comments?
> > 
> > 	Hiroshi DOYU
> > 
> > From: "ext Ramirez Luna, Omar" <x00omar@ti.com>
> > Subject: [PATCH 2/3][OMAP 3/4]table end for wcd command definitions
> > Date: Thu, 28 Aug 2008 20:30:44 -0500
> > 
> > > Added the table end 'CMD_BASE_END_OFFSET' define in wcdioctl.h
> > > 
> > > Signed-off-by: Omar Ramirez Luna <x00omar@ti.com>
> > > ---
> > > 
> > > Index: omapkernel/arch/arm/plat-omap/include/mach/bridge/wcdioctl.h
> > > ===================================================================
> > > --- omapkernel.orig/arch/arm/plat-omap/include/mach/bridge/wcdioctl.h	2008-08-22 19:03:10.000000000 -0500
> > > +++ omapkernel/arch/arm/plat-omap/include/mach/bridge/wcdioctl.h	2008-08-22 19:20:05.000000000 -0500
> > > @@ -515,4 +515,5 @@
> > >  #define CMD_CMM_GETINFO_OFFSET	  (CMD_CMM_BASE_OFFSET + 3)
> > >  #define CMD_CMM_END_OFFSET	      CMD_CMM_GETINFO_OFFSET
> > >  
> > > +#define CMD_BASE_END_OFFSET	CMD_CMM_END_OFFSET
> > >  #endif				/* WCDIOCTL_ */
> > > --
> > > To unsubscribe from this list: send the line "unsubscribe linux-omap" in
> > > the body of a message to majordomo@vger.kernel.org
> > > More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH 2/3][OMAP 3/4]table end for wcd command definitions

[Russell King - ARM Linux]

On Wed, Sep 10, 2008 at 08:44:14AM -0700, Tony Lindgren wrote:
> * Hiroshi DOYU <Hiroshi.DOYU@nokia.com> [080909 21:08]:
> > Hi,
> > 
> > Although this TI bridge patches are not integrated and a bit
> > independent S/W component, it would be nice to get some comments just
> > on this bridge header file location from kernel maintainer's
> > perspective.
> > 
> > "arch/arm/plat-omap/include/mach/bridge"
> >   or "arch/arm/plat-omap/include/bridge"?
> 
> How about put the bridge specific headers under include/linux/dspbridge?
> Then you can have just the omap specific headers under
> arch/arm/plat-omap/include/mach.

There's an advantage to having them under arch/arm/plat-omap/include/dspbridge
- it's portable.  If ever they need to become more visible, they can be easily
moved to arch/arm/include/dspbridge or include/dspbridge instead.

Re: [PATCH 2/3][OMAP 3/4]table end for wcd command definitions

[Hiroshi DOYU]

Thanks for your comments.

From: "ext Russell King - ARM Linux" <linux@arm.linux.org.uk>
Subject: Re: [PATCH 2/3][OMAP 3/4]table end for wcd command definitions
Date: Wed, 10 Sep 2008 20:38:30 +0100

> On Wed, Sep 10, 2008 at 08:44:14AM -0700, Tony Lindgren wrote:
> > * Hiroshi DOYU <Hiroshi.DOYU@nokia.com> [080909 21:08]:
> > > Hi,
> > > 
> > > Although this TI bridge patches are not integrated and a bit
> > > independent S/W component, it would be nice to get some comments just
> > > on this bridge header file location from kernel maintainer's
> > > perspective.
> > > 
> > > "arch/arm/plat-omap/include/mach/bridge"
> > >   or "arch/arm/plat-omap/include/bridge"?
> > 
> > How about put the bridge specific headers under include/linux/dspbridge?
> > Then you can have just the omap specific headers under
> > arch/arm/plat-omap/include/mach.
> 
> There's an advantage to having them under arch/arm/plat-omap/include/dspbridge
> - it's portable.  If ever they need to become more visible, they can be easily
> moved to arch/arm/include/dspbridge or include/dspbridge instead.

"arch/arm/plat-omap/include/dspbridge" sounds reasonable, at least,
for the meanwhile.

For this header file directory name, 'dsp' prefix is needed in
"include/'dsp'bridge" because "bridge" is too generic naming and,
instead, "drivers/'dsp'/bridge" has 'dsp' in its path already.

	Hiroshi DOYU

RE: [PATCH 2/3][OMAP 3/4]table end for wcd command definitions

[Kanigeri, Hari]

Thank you for suggesting this. We will make this change.

Thank you,
Best regards,
Hari

> -----Original Message-----
> From: Hiroshi DOYU [mailto:Hiroshi.DOYU@nokia.com]
> Sent: Wednesday, September 10, 2008 10:22 PM
> To: linux@arm.linux.org.uk
> Cc: tony@atomide.com; linux-omap@vger.kernel.org; Ramirez Luna, Omar;
> Pandita, Vikram; Guzman Lugo, Fernando; Kanigeri, Hari
> Subject: Re: [PATCH 2/3][OMAP 3/4]table end for wcd command definitions
> 
> Thanks for your comments.
> 
> From: "ext Russell King - ARM Linux" <linux@arm.linux.org.uk>
> Subject: Re: [PATCH 2/3][OMAP 3/4]table end for wcd command definitions
> Date: Wed, 10 Sep 2008 20:38:30 +0100
> 
> > On Wed, Sep 10, 2008 at 08:44:14AM -0700, Tony Lindgren wrote:
> > > * Hiroshi DOYU <Hiroshi.DOYU@nokia.com> [080909 21:08]:
> > > > Hi,
> > > >
> > > > Although this TI bridge patches are not integrated and a bit
> > > > independent S/W component, it would be nice to get some comments
> just
> > > > on this bridge header file location from kernel maintainer's
> > > > perspective.
> > > >
> > > > "arch/arm/plat-omap/include/mach/bridge"
> > > >   or "arch/arm/plat-omap/include/bridge"?
> > >
> > > How about put the bridge specific headers under
> include/linux/dspbridge?
> > > Then you can have just the omap specific headers under
> > > arch/arm/plat-omap/include/mach.
> >
> > There's an advantage to having them under arch/arm/plat-
> omap/include/dspbridge
> > - it's portable.  If ever they need to become more visible, they can be
> easily
> > moved to arch/arm/include/dspbridge or include/dspbridge instead.
> 
> "arch/arm/plat-omap/include/dspbridge" sounds reasonable, at least,
> for the meanwhile.
> 
> For this header file directory name, 'dsp' prefix is needed in
> "include/'dsp'bridge" because "bridge" is too generic naming and,
> instead, "drivers/'dsp'/bridge" has 'dsp' in its path already.
> 
> 	Hiroshi DOYU
> 
> 

Re: [PATCH 2/3][OMAP 3/4]table end for wcd command definitions

[Hiroshi DOYU]

JFYI, you can get all the updates against "l-o" from:

http://4869037.web.fc2.com/tidspbridge-20080911.tgz

which has already included the following changes too.

From: "ext Kanigeri, Hari" <h-kanigeri2@ti.com>
Subject: RE: [PATCH 2/3][OMAP 3/4]table end for wcd command definitions
Date: Thu, 11 Sep 2008 13:47:56 -0500

> Thank you for suggesting this. We will make this change.
> 
> Thank you,
> Best regards,
> Hari
> 
> > -----Original Message-----
> > From: Hiroshi DOYU [mailto:Hiroshi.DOYU@nokia.com]
> > Sent: Wednesday, September 10, 2008 10:22 PM
> > To: linux@arm.linux.org.uk
> > Cc: tony@atomide.com; linux-omap@vger.kernel.org; Ramirez Luna, Omar;
> > Pandita, Vikram; Guzman Lugo, Fernando; Kanigeri, Hari
> > Subject: Re: [PATCH 2/3][OMAP 3/4]table end for wcd command definitions
> > 
> > Thanks for your comments.
> > 
> > From: "ext Russell King - ARM Linux" <linux@arm.linux.org.uk>
> > Subject: Re: [PATCH 2/3][OMAP 3/4]table end for wcd command definitions
> > Date: Wed, 10 Sep 2008 20:38:30 +0100
> > 
> > > On Wed, Sep 10, 2008 at 08:44:14AM -0700, Tony Lindgren wrote:
> > > > * Hiroshi DOYU <Hiroshi.DOYU@nokia.com> [080909 21:08]:
> > > > > Hi,
> > > > >
> > > > > Although this TI bridge patches are not integrated and a bit
> > > > > independent S/W component, it would be nice to get some comments
> > just
> > > > > on this bridge header file location from kernel maintainer's
> > > > > perspective.
> > > > >
> > > > > "arch/arm/plat-omap/include/mach/bridge"
> > > > >   or "arch/arm/plat-omap/include/bridge"?
> > > >
> > > > How about put the bridge specific headers under
> > include/linux/dspbridge?
> > > > Then you can have just the omap specific headers under
> > > > arch/arm/plat-omap/include/mach.
> > >
> > > There's an advantage to having them under arch/arm/plat-
> > omap/include/dspbridge
> > > - it's portable.  If ever they need to become more visible, they can be
> > easily
> > > moved to arch/arm/include/dspbridge or include/dspbridge instead.
> > 
> > "arch/arm/plat-omap/include/dspbridge" sounds reasonable, at least,
> > for the meanwhile.
> > 
> > For this header file directory name, 'dsp' prefix is needed in
> > "include/'dsp'bridge" because "bridge" is too generic naming and,
> > instead, "drivers/'dsp'/bridge" has 'dsp' in its path already.
> > 
> > 	Hiroshi DOYU
> > 
> > 
>