From: Tony Lindgren <tony@atomide.com>
To: "stanley.miao" <stanley.miao@windriver.com>
Cc: "linux-omap@vger.kernel.org" <linux-omap@vger.kernel.org>
Subject: Re: [PATCH] ARM: OMAP3: Fix omapfb's problem on OMAP3430sdp
Date: Wed, 10 Sep 2008 10:46:08 -0700 [thread overview]
Message-ID: <20080910174607.GC21163@atomide.com> (raw)
In-Reply-To: <1220844597.28777.12.camel@localhost>
* stanley.miao <stanley.miao@windriver.com> [080907 20:28]:
> Prune off a empty line.
>
> Fix omapfb's problem on OMAP3430sdp.
Pushing today.
Tony
>
> ---
> drivers/video/omap/lcd_2430sdp.c | 17 +++++++++++++++++
> 1 files changed, 17 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/video/omap/lcd_2430sdp.c
> b/drivers/video/omap/lcd_2430sdp.c
> index 9af6cd0..b456e02 100644
> --- a/drivers/video/omap/lcd_2430sdp.c
> +++ b/drivers/video/omap/lcd_2430sdp.c
> @@ -23,6 +23,7 @@
>
> #include <linux/module.h>
> #include <linux/platform_device.h>
> +#include <linux/delay.h>
> #include <linux/i2c/twl4030.h>
>
> #include <mach/gpio.h>
> @@ -45,6 +46,10 @@ static unsigned enable_gpio;
> #define ENABLE_VAUX3_DEDICATED 0x03
> #define ENABLE_VAUX3_DEV_GRP 0x20
>
> +#define ENABLE_VPLL2_DEDICATED 0x05
> +#define ENABLE_VPLL2_DEV_GRP 0xE0
> +#define TWL4030_VPLL2_DEV_GRP 0x33
> +#define TWL4030_VPLL2_DEDICATED 0x36
>
> #define t2_out(c, r, v) twl4030_i2c_write_u8(c, r, v)
>
> @@ -82,6 +87,13 @@ static int sdp2430_panel_enable(struct lcd_panel
> *panel)
> ded_val = ENABLE_VAUX3_DEDICATED;
> grp_reg = TWL4030_VAUX3_DEV_GRP;
> grp_val = ENABLE_VAUX3_DEV_GRP;
> +
> + if (is_sil_rev_greater_than(OMAP3430_REV_ES1_0)) {
> + t2_out(PM_RECEIVER, ENABLE_VPLL2_DEDICATED,
> + TWL4030_VPLL2_DEDICATED);
> + t2_out(PM_RECEIVER, ENABLE_VPLL2_DEV_GRP,
> + TWL4030_VPLL2_DEV_GRP);
> + }
> } else {
> ded_reg = TWL4030_VAUX2_DEDICATED;
> ded_val = ENABLE_VAUX2_DEDICATED;
> @@ -104,6 +116,11 @@ static void sdp2430_panel_disable(struct lcd_panel
> *panel)
> {
> omap_set_gpio_dataout(enable_gpio, 0);
> omap_set_gpio_dataout(backlight_gpio, 0);
> + if (is_sil_rev_greater_than(OMAP3430_REV_ES1_0)) {
> + t2_out(PM_RECEIVER, 0x0, TWL4030_VPLL2_DEDICATED);
> + t2_out(PM_RECEIVER, 0x0, TWL4030_VPLL2_DEV_GRP);
> + mdelay(4);
> + }
> }
>
> static unsigned long sdp2430_panel_get_caps(struct lcd_panel *panel)
> --
> 1.5.6.3
>
next prev parent reply other threads:[~2008-09-10 17:46 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-09-08 2:42 [PATCH] ARM: OMAP3: Fix omapfb's problem on OMAP3430sdp stanley.miao
2008-09-08 3:29 ` stanley.miao
2008-09-10 17:46 ` Tony Lindgren [this message]
-- strict thread matches above, loose matches on Subject: below --
2008-09-01 13:37 stanley.miao
2008-09-02 4:33 ` Gadiyar, Anand
2008-09-02 5:49 ` arun c
2008-09-02 6:13 ` stanley.miao
2008-09-02 8:14 ` Felipe Balbi
2008-09-02 9:33 ` stanley.miao
2008-09-05 17:13 ` Tony Lindgren
2008-09-08 2:27 ` stanley.miao
2008-09-02 14:51 ` David Brownell
2008-09-03 1:53 ` stanley.miao
2008-09-03 1:55 ` David Brownell
2008-09-03 3:40 ` stanley.miao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080910174607.GC21163@atomide.com \
--to=tony@atomide.com \
--cc=linux-omap@vger.kernel.org \
--cc=stanley.miao@windriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox