From: David Brownell <david-b@pacbell.net>
To: vimal singh <vimalsingh@ti.com>
Cc: tony@atomide.com, linux-omap@vger.kernel.org
Subject: Re: [RESENDING][PATCH 1/2]OMAP3 NAND: Add NAND support on OMAP3430
Date: Wed, 10 Sep 2008 23:21:43 -0700 [thread overview]
Message-ID: <200809102321.44169.david-b@pacbell.net> (raw)
In-Reply-To: <33923.192.168.10.89.1221112794.squirrel@dbdmail.itg.ti.com>
On Wednesday 10 September 2008, vimal singh wrote:
> [VS: updated for SZ_.. macros]
> + /* All the partition sizes are listed in terms of NAND block size
> ...
> + .size = SZ_512K,
> ...
> + .size = SZ_512K,
> ...
But now they're not "in terms of NAND block size".
Wouldn't it be better to use either 4 * SZ_128K or 4 * NAND_BLOCK_SIZE?
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2008-09-11 6:21 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <41054.192.168.10.89.1219747319.squirrel@dbdmail.itg.ti.com>
2008-09-11 5:59 ` [RESENDING][PATCH 1/2]OMAP3 NAND: Add NAND support on OMAP3430 vimal singh
2008-09-11 6:21 ` David Brownell [this message]
2008-09-11 8:50 ` Singh, Vimal
2008-09-11 9:31 ` David Brownell
[not found] ` <33923.192.168.10.89.1221112795.squirrel@dbdmail.itg.ti.com>
2008-09-11 10:06 ` vimal singh
2008-10-06 11:20 ` Tony Lindgren
2008-10-06 16:37 ` David Brownell
2008-10-07 5:28 ` Singh, Vimal
2008-08-26 10:41 vimal singh
2008-09-11 0:11 ` Tony Lindgren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200809102321.44169.david-b@pacbell.net \
--to=david-b@pacbell.net \
--cc=linux-omap@vger.kernel.org \
--cc=tony@atomide.com \
--cc=vimalsingh@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox