public inbox for linux-omap@vger.kernel.org
 help / color / mirror / Atom feed
From: Tony Lindgren <tony@atomide.com>
To: "Woodruff, Richard" <r-woodruff2@ti.com>
Cc: Jarkko Lavinen <jarkko.lavinen@nokia.com>,
	"linux-omap@vger.kernel.org" <linux-omap@vger.kernel.org>
Subject: Re: HSMMC pending fixes
Date: Wed, 10 Sep 2008 17:05:06 -0700	[thread overview]
Message-ID: <20080911000506.GX21163@atomide.com> (raw)
In-Reply-To: <13B9B4C6EF24D648824FF11BE8967162036217F3A9@dlee02.ent.ti.com>

* Woodruff, Richard <r-woodruff2@ti.com> [080818 14:09]:
> Hi,
> 
> > owner@vger.kernel.org] On Behalf Of Jarkko Lavinen
> 
> 
> > 2: Disable smartidle mode while suspending (workaround)
> 
> This was the work around we had in internal trees for a long time.
> 
> However Madhu C. recently updated this based on an internal investigation.  It is required to reset the command pin to clear the system for sleep.  This allows retention to work.
> 
> The non-idle work around when profiled showed it was taking a huge amount of time for the clock re-enable to work.  This actually would noticeably reduce MMC throughput when doing aggressive clock cutting in the driver and increase power usage.
> 
> +       } else {
> +               OMAP_HSMMC_WRITE(host->base, SYSCTL,
> +                       OMAP_HSMMC_READ(host->base, SYSCTL) | SRD);
> +               while (OMAP_HSMMC_READ(host->base, SYSCTL) & SRD) ;
> 
> If you use a really long time out then perhaps it doesn't matter.  But if you try and be aggressive it will hurt you.

Pushing all except the workaround. Madhu, can you please send a patch
for what Richard is describing?

Thanks,

Tony

  reply	other threads:[~2008-09-11  0:05 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-08-18 15:13 HSMMC pending fixes Jarkko Lavinen
2008-08-18 15:13 ` [PATCH] OMAP: HSMMC: Check wether board specific suspend / resume exists Jarkko Lavinen
2008-08-18 15:13   ` [PATCH] MMC: OMAP: Disable smartidle mode while suspending (workaround) Jarkko Lavinen
2008-08-18 15:13     ` [PATCH] MMC: OMAP: Readable output for IRQ status register Jarkko Lavinen
2008-08-18 15:13       ` [PATCH] MMC: OMAP: Re-organizing some goto at hsmmc probe Jarkko Lavinen
2008-08-18 15:13         ` [PATCH] MMC: OMAP: Add slot_name entry to sysfs Jarkko Lavinen
2008-08-18 15:13           ` [PATCH] MMC: Add sysfs file cover_switch Jarkko Lavinen
2008-08-21 13:23         ` [PATCH] MMC: OMAP: Re-organizing some goto at hsmmc probe Madhusudhan Chikkature
2008-08-18 21:07 ` HSMMC pending fixes Woodruff, Richard
2008-09-11  0:05   ` Tony Lindgren [this message]
2008-09-11  4:13     ` Madhusudhan Chikkature
2008-09-12 17:58       ` Tony Lindgren

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080911000506.GX21163@atomide.com \
    --to=tony@atomide.com \
    --cc=jarkko.lavinen@nokia.com \
    --cc=linux-omap@vger.kernel.org \
    --cc=r-woodruff2@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox