From: David Brownell <david-b@pacbell.net>
To: "Singh, Vimal" <vimalsingh@ti.com>
Cc: "tony@atomide.com" <tony@atomide.com>,
"linux-omap@vger.kernel.org" <linux-omap@vger.kernel.org>
Subject: Re: [RESENDING][PATCH 1/2]OMAP3 NAND: Add NAND support on OMAP3430
Date: Thu, 11 Sep 2008 02:31:47 -0700 [thread overview]
Message-ID: <200809110231.47453.david-b@pacbell.net> (raw)
In-Reply-To: <19F8576C6E063C45BE387C64729E739403CD517C4B@dbde02.ent.ti.com>
On Thursday 11 September 2008, Singh, Vimal wrote:
> I will define NAND_BLOCK_SIZE as:
> #define NAND_BLOCK_SIZE 64 * NAND_MAX_PAGESIZE
Never define such things without parentheses ...
Also, that looks wrong as well as sub-optimal. Current NAND chips
can have page sizes up to 4 KB (right?), so I think "MAX" isn't
what you would want (even if it never grows again).
I'd just use SZ_128K for NAND_BLOCK_SIZE, and avoid the confusion.
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2008-09-11 9:32 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <41054.192.168.10.89.1219747319.squirrel@dbdmail.itg.ti.com>
2008-09-11 5:59 ` [RESENDING][PATCH 1/2]OMAP3 NAND: Add NAND support on OMAP3430 vimal singh
2008-09-11 6:21 ` David Brownell
2008-09-11 8:50 ` Singh, Vimal
2008-09-11 9:31 ` David Brownell [this message]
[not found] ` <33923.192.168.10.89.1221112795.squirrel@dbdmail.itg.ti.com>
2008-09-11 10:06 ` vimal singh
2008-10-06 11:20 ` Tony Lindgren
2008-10-06 16:37 ` David Brownell
2008-10-07 5:28 ` Singh, Vimal
2008-08-26 10:41 vimal singh
2008-09-11 0:11 ` Tony Lindgren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200809110231.47453.david-b@pacbell.net \
--to=david-b@pacbell.net \
--cc=linux-omap@vger.kernel.org \
--cc=tony@atomide.com \
--cc=vimalsingh@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox