Re: [RFC] OMAP3: GPIO: Enable debounce clock only when debounce is enabled

[Daniel Stone <daniel.stone@nokia.com>]

[-- Attachment #1: Type: text/plain, Size: 1291 bytes --]

On Fri, Sep 12, 2008 at 01:51:38PM +0300, ext Jouni Hogander wrote:
> This patch changes gpio "driver" to enable debounce clock for
> gpio-bank only when debounce is enabled for some gpio in that bank.
> 
> This patch obsoletes "PM: Dynamic GPIO clock handling" patch. Nasty
> side effect is that gpios in per domain aren't capable to generate
> wake-up if per domain is in sleep state. Anyway keeping dbcks enabled
> all the time isn't either good way to workaround this problem. For
> this we need to use iopad wake-up. Currently enabling iopad wakeup
> mechanism for gpio pads is left for bootloader or kernel (depending
> which one does the configuration)
> 
> Signed-off-by: Jouni Hogander <jouni.hogander@nokia.com>
> ---
>  arch/arm/plat-omap/gpio.c |   26 +++++++++++++++++---------
>  1 files changed, 17 insertions(+), 9 deletions(-)
> 
> diff --git a/arch/arm/plat-omap/gpio.c b/arch/arm/plat-omap/gpio.c
> index 0e74103..da164d8 100644
> --- a/arch/arm/plat-omap/gpio.c
> +++ b/arch/arm/plat-omap/gpio.c
> @@ -152,6 +152,9 @@ struct gpio_bank {
>  	u32 level_mask;
>  	spinlock_t lock;
>  	struct gpio_chip chip;
> +#if defined(CONFIG_ARCH_OMAP3)
> +	struct clk *dbck
                        ^
                        ;
> +#endif

Cheers,
Daniel

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 197 bytes --]