From: David Brownell <david-b@pacbell.net>
To: "Gadiyar, Anand" <gadiyar@ti.com>
Cc: "me@felipebalbi.com" <me@felipebalbi.com>,
Tony Lindgren <tony@atomide.com>,
"felipe.balbi@nokia.com" <felipe.balbi@nokia.com>,
Linux OMAP Mailing List <linux-omap@vger.kernel.org>
Subject: Re: [rfc] [patch] clean up to ehci-omap (Was: Re: [patch] omap: usb: ehci: fix use of hcd->regs)
Date: Fri, 12 Sep 2008 14:15:09 -0700 [thread overview]
Message-ID: <200809121415.09398.david-b@pacbell.net> (raw)
In-Reply-To: <5A47E75E594F054BAF48C5E4FC4B92AB02C4007EC5@dbde02.ent.ti.com>
On Friday 12 September 2008, Gadiyar, Anand wrote:
>
> > Sounds like code that can live in mach-omap2 and be called
> > when the drivers start or stop.
>
>
> Yup. Then a lot of the code in that ehci-omap.c file would need
> to be moved there to avoid duplicating code. Will do that when
> I add the OHCI bus-glue.
OK. To clarify: it could also be argued that such stuff
should be in some bit of drivers/usb/host code ... but from
my previous exposure to OMAP USB stuff, I assume this kind
of code will be a lot more SOC-sensitive (revisions etc)
than we like to see in the USB tree. The setup bits (how
to mux pins and configure the transceiver) clearly belongs
in mach-omap2/usb-SOMETHING.c and if anything clearly doesn't
belong there, it can move.
next prev parent reply other threads:[~2008-09-13 0:42 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-09-12 12:10 [patch] omap: usb: ehci: fix use of hcd->regs Felipe Balbi
2008-09-12 12:14 ` Hiroshi DOYU
2008-09-12 12:30 ` Felipe Balbi
2008-09-12 13:37 ` Hiroshi DOYU
2008-09-14 18:53 ` Pandita, Vikram
2008-09-12 16:32 ` David Brownell
2008-09-12 17:50 ` Felipe Balbi
2008-09-12 18:22 ` Felipe Balbi
2008-09-12 18:38 ` [rfc] [patch] clean up to ehci-omap (Was: Re: [patch] omap: usb: ehci: fix use of hcd->regs) Felipe Balbi
2008-09-12 19:16 ` David Brownell
2008-09-12 19:21 ` Tony Lindgren
2008-09-12 19:28 ` Felipe Balbi
2008-09-12 19:29 ` Felipe Balbi
2008-09-12 19:35 ` Felipe Balbi
2008-09-14 18:41 ` Pandita, Vikram
2008-09-14 18:57 ` Felipe Balbi
2008-09-16 5:47 ` David Brownell
2008-09-16 7:26 ` Felipe Balbi
2008-09-16 5:48 ` David Brownell
2008-09-16 6:05 ` Gadiyar, Anand
2008-09-16 6:35 ` David Brownell
2008-09-16 7:28 ` Felipe Balbi
2008-09-16 5:49 ` David Brownell
2008-09-16 8:28 ` Felipe Balbi
2008-09-18 9:35 ` Gadiyar, Anand
2008-09-21 23:28 ` Paul Walmsley
2008-09-22 15:17 ` Felipe Balbi
2008-09-22 15:21 ` Gadiyar, Anand
2008-09-22 15:26 ` Felipe Balbi
2008-09-22 15:30 ` Gadiyar, Anand
2008-09-22 15:32 ` Felipe Balbi
2008-09-12 20:01 ` Gadiyar, Anand
2008-09-12 20:30 ` David Brownell
2008-09-12 20:54 ` Gadiyar, Anand
2008-09-12 21:15 ` David Brownell [this message]
2008-09-12 20:38 ` Felipe Balbi
2008-09-12 21:06 ` Gadiyar, Anand
2008-09-12 22:18 ` Steve Sakoman
2008-09-12 23:54 ` [patch] omap: usb: ehci: fix use of hcd->regs Tony Lindgren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200809121415.09398.david-b@pacbell.net \
--to=david-b@pacbell.net \
--cc=felipe.balbi@nokia.com \
--cc=gadiyar@ti.com \
--cc=linux-omap@vger.kernel.org \
--cc=me@felipebalbi.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox