From: Tony Lindgren <tony@atomide.com>
To: Felipe Balbi <felipe.balbi@nokia.com>
Cc: ext Peter 'p2' De Schrijver <peter.de-schrijver@nokia.com>,
linux-omap@vger.kernel.org
Subject: Re: [PATCH] Fix build for beagleboard
Date: Fri, 12 Sep 2008 10:21:03 -0700 [thread overview]
Message-ID: <20080912172102.GA10675@atomide.com> (raw)
In-Reply-To: <20080912120625.GF759@gandalf.research.nokia.com>
* Felipe Balbi <felipe.balbi@nokia.com> [080912 05:07]:
> Hi Tony,
>
> please amend the following into this patch:
>
> On Fri, Sep 12, 2008 at 01:32:36PM +0300, Peter 'p2' De Schrijver wrote:
> >
> > Signed-off-by: Peter 'p2' De Schrijver <peter.de-schrijver@nokia.com>
> > ---
> > drivers/i2c/chips/twl4030-power.c | 5 ++++-
> > 1 files changed, 4 insertions(+), 1 deletions(-)
> >
> > diff --git a/drivers/i2c/chips/twl4030-power.c b/drivers/i2c/chips/twl4030-power.c
> > index 195c3c4..04a13aa 100644
> > --- a/drivers/i2c/chips/twl4030-power.c
> > +++ b/drivers/i2c/chips/twl4030-power.c
> > @@ -149,7 +149,7 @@ struct triton_ins t2_wrst_seq[] __initdata = {
> > struct triton_ins sleep_on_seq[] __initdata = {
> > {MSG_BROADCAST(DEV_GRP_NULL, RES_GRP_RC, RES_TYPE_ALL, RES_TYPE2_R0,
> > RES_STATE_SLEEP), 4},
> > - {MSG_BROADCAST(DEV_GRP_NULL, RES_GRP_ALL, RES_TYPE_ALL, RES_TYPE_R7,
> > + {MSG_BROADCAST(DEV_GRP_NULL, RES_GRP_ALL, RES_TYPE_ALL, RES_TYPE2_R0,
> > RES_STATE_SLEEP), 4},
> > };
> >
> > @@ -160,6 +160,9 @@ struct triton_ins sleep_off_seq[] __initdata = {
> > {MSG_BROADCAST(DEV_GRP_NULL, RES_GRP_ALL, RES_TYPE_ALL, RES_TYPE2_R0,
> > RES_STATE_ACTIVE), 0x2},
> > };
> > +
> > +struct triton_ins t2_wrst_seq[] __initdata = { };
> > +
> > #endif
> >
> > static int __init twl4030_write_script_byte(u8 address, u8 byte)
>
> diff -u b/drivers/i2c/chips/twl4030-power.c b/drivers/i2c/chips/twl4030-power.c
> --- b/drivers/i2c/chips/twl4030-power.c
> +++ b/drivers/i2c/chips/twl4030-power.c
> @@ -215,7 +215,6 @@
> static int __init config_sleep_wake_sequence(void)
> {
> int err = 0;
> - u8 data;
>
> /*
> * CLKREQ is pulled high on the 2430SDP, therefore, we need to take
>
Thanks, pushed with this change.
Tony
next prev parent reply other threads:[~2008-09-12 17:21 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-09-11 11:50 [PATCH] Fix for twl4030-power.c build failure for beagleboard Peter 'p2' De Schrijver
2008-09-11 11:50 ` [PATCH] Fix build " Peter 'p2' De Schrijver
2008-09-11 18:15 ` Tony Lindgren
2008-09-12 10:32 ` [PATCH] *** SUBJECT HERE *** Peter 'p2' De Schrijver
2008-09-12 10:32 ` [PATCH] Fix build for beagleboard Peter 'p2' De Schrijver
2008-09-12 12:06 ` Felipe Balbi
2008-09-12 17:21 ` Tony Lindgren [this message]
2008-09-12 14:02 ` Paul Walmsley
2008-09-12 10:31 ` Felipe Balbi
-- strict thread matches above, loose matches on Subject: below --
2008-09-15 18:23 [patch] kill compile warning on twl4030-power.c Felipe Balbi
2008-09-16 12:29 ` [PATCH] Fix build for beagleboard Peter 'p2' De Schrijver
2008-09-23 10:54 ` Tony Lindgren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080912172102.GA10675@atomide.com \
--to=tony@atomide.com \
--cc=felipe.balbi@nokia.com \
--cc=linux-omap@vger.kernel.org \
--cc=peter.de-schrijver@nokia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox