omapfb not working on beagleboard

omapfb not working on beagleboard

[Felipe Contreras]

Hi,

I was getting bad image with the current omapfb on the Beagle Board
until Mans Rullgard told me to change the bits per pixel to 16.

Is there any reason why it's 24?
drivers/video/omap/lcd_omap3beagle.c

-- 
Felipe Contreras

Re: omapfb not working on beagleboard

[arun c]

On Fri, Sep 12, 2008 at 4:52 PM, Felipe Contreras
<felipe.contreras@gmail.com> wrote:
> Hi,
>
> I was getting bad image with the current omapfb on the Beagle Board
> until Mans Rullgard told me to change the bits per pixel to 16.
>
> Is there any reason why it's 24?

As far as I know omapfb doesn't support 24bpp.


> drivers/video/omap/lcd_omap3beagle.c
>
> --
> Felipe Contreras
> --
> To unsubscribe from this list: send the line "unsubscribe linux-omap" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>

[PATCH] omapfb: use proper bits per pixel for beagleboard.

[Felipe Contreras]

This was suggested by Mans Rullgard, otherwise it doesn't work.

Signed-off-by: Felipe Contreras <felipe.contreras@gmail.com>
---
 drivers/video/omap/lcd_omap3beagle.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/video/omap/lcd_omap3beagle.c b/drivers/video/omap/lcd_omap3beagle.c
index 9637735..dc59f39 100644
--- a/drivers/video/omap/lcd_omap3beagle.c
+++ b/drivers/video/omap/lcd_omap3beagle.c
@@ -66,7 +66,7 @@ struct lcd_panel omap3beagle_panel = {
 	.name		= "omap3beagle",
 	.config		= OMAP_LCDC_PANEL_TFT,
 
-	.bpp		= 24,
+	.bpp		= 16,
 	.data_lines	= 24,
 	.x_res		= LCD_XRES,
 	.y_res		= LCD_YRES,
-- 
1.6.0.1

Re: [PATCH] omapfb: use proper bits per pixel for beagleboard.

[Tony Lindgren]

* Felipe Contreras <felipe.contreras@gmail.com> [080912 15:28]:
> This was suggested by Mans Rullgard, otherwise it doesn't work.

Pushing today.

Tony

> 
> Signed-off-by: Felipe Contreras <felipe.contreras@gmail.com>
> ---
>  drivers/video/omap/lcd_omap3beagle.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/video/omap/lcd_omap3beagle.c b/drivers/video/omap/lcd_omap3beagle.c
> index 9637735..dc59f39 100644
> --- a/drivers/video/omap/lcd_omap3beagle.c
> +++ b/drivers/video/omap/lcd_omap3beagle.c
> @@ -66,7 +66,7 @@ struct lcd_panel omap3beagle_panel = {
>  	.name		= "omap3beagle",
>  	.config		= OMAP_LCDC_PANEL_TFT,
>  
> -	.bpp		= 24,
> +	.bpp		= 16,
>  	.data_lines	= 24,
>  	.x_res		= LCD_XRES,
>  	.y_res		= LCD_YRES,
> -- 
> 1.6.0.1
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-omap" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html