From: Felipe Balbi <me@felipebalbi.com>
To: Peter 'p2' De Schrijver <peter.de-schrijver@nokia.com>
Cc: ext Felipe Balbi <me@felipebalbi.com>,
Linux OMAP Mailing List <linux-omap@vger.kernel.org>
Subject: Re: [patch] kill compile warning on twl4030-power.c
Date: Mon, 15 Sep 2008 21:23:02 +0300 [thread overview]
Message-ID: <20080915182259.GB7782@frodo> (raw)
In-Reply-To: <20080915173020.GI4712@codecarver.research.nokia.com>
On Mon, Sep 15, 2008 at 08:30:20PM +0300, Peter 'p2' De Schrijver wrote:
> > > > -#if defined(CONFIG_MACH_OMAP_3430SDP) || defined(CONFIG_MACH_OMAP_3430LABRADOR)
> > > > - /* Disabling AC charger effect on sleep-active transitions */
> > > > - err |= twl4030_i2c_read_u8(TWL4030_MODULE_PM_MASTER, &data,
> > > > - R_CFG_P1_TRANSITION);
> > > > - data &= 0x0;
> > >
> > > This does not make sense :)
> >
> > Why not? That data variable is only used on 3430SDP and LABRADOR
> > anyways. Any other build will keep generating "unused variable" warnings
> > and that's annoying :-p
>
> Because a logical and with 0 will always result in 0. So the read is
> useless. So the original code is probably wrong.
Maybe you meant data &= ~(1 << 0); ???
--
balbi
next prev parent reply other threads:[~2008-09-15 18:23 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-09-15 15:12 [patch] kill compile warning on twl4030-power.c Felipe Balbi
2008-09-15 15:55 ` Peter 'p2' De Schrijver
2008-09-15 16:21 ` Felipe Balbi
2008-09-15 16:23 ` Felipe Balbi
2008-09-15 16:24 ` Peter 'p2' De Schrijver
2008-09-15 16:36 ` Felipe Balbi
2008-09-15 17:30 ` Peter 'p2' De Schrijver
2008-09-15 17:34 ` Felipe Balbi
2008-09-15 18:23 ` Felipe Balbi [this message]
2008-09-16 12:29 ` [PATCH] Fix build for beagleboard Peter 'p2' De Schrijver
2008-09-23 10:54 ` Tony Lindgren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080915182259.GB7782@frodo \
--to=me@felipebalbi.com \
--cc=linux-omap@vger.kernel.org \
--cc=peter.de-schrijver@nokia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox