From: Felipe Balbi <me@felipebalbi.com>
To: Russell King - ARM Linux <linux@arm.linux.org.uk>
Cc: Felipe Balbi <me@felipebalbi.com>,
linux-omap@vger.kernel.org, Tony Lindgren <tony@atomide.com>,
David Brownell <david-b@pacbell.net>,
"George G. Davis" <gdavis@mvista.com>,
Wim Van Sebroeck <wim@iguana.be>,
Felipe Balbi <felipe.balbi@nokia.com>
Subject: Re: [PATCH 4/5] watchdog: cleanup a bit omap_wdt.c
Date: Fri, 19 Sep 2008 02:18:32 +0300 [thread overview]
Message-ID: <20080918231831.GL6617@frodo> (raw)
In-Reply-To: <20080918231021.GH14307@flint.arm.linux.org.uk>
On Fri, Sep 19, 2008 at 12:10:21AM +0100, Russell King - ARM Linux wrote:
> On Fri, Sep 19, 2008 at 01:23:41AM +0300, Felipe Balbi wrote:
> > +
> > return 0;
> > }
> > -
> > -#else
> > -#define omap_wdt_suspend NULL
> > -#define omap_wdt_resume NULL
> > #endif
> >
> > static struct platform_driver omap_wdt_driver = {
> > .probe = omap_wdt_probe,
> > .remove = omap_wdt_remove,
> > +#ifdef CONFIG_PM
> > .shutdown = omap_wdt_shutdown,
> > .suspend = omap_wdt_suspend,
> > +#endif
>
> I prefer to see the function names defined to NULL rather than adding
> extra ifdefs into drivers.
Reverted.
--
balbi
next prev parent reply other threads:[~2008-09-18 23:18 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-09-18 22:23 [RFC] [PATCH 0/5] omap watchdog fixes Felipe Balbi
2008-09-18 22:23 ` [PATCH 1/5] watchdog: sync linux-omap changes Felipe Balbi
2008-09-18 22:23 ` [PATCH 2/5] watchdog: another ioremap() fix Felipe Balbi
2008-09-18 22:23 ` [PATCH 3/5] watchdog: move omap_wdt.h to include/linux/watchdog Felipe Balbi
2008-09-18 22:23 ` [PATCH 4/5] watchdog: cleanup a bit omap_wdt.c Felipe Balbi
2008-09-18 22:23 ` [PATCH 5/5] watchdog: introduce platform_data and remove cpu conditional code Felipe Balbi
2008-09-18 23:20 ` Russell King - ARM Linux
2008-09-18 23:23 ` Felipe Balbi
2008-09-19 7:46 ` Russell King - ARM Linux
2008-09-19 8:15 ` Felipe Balbi
2008-09-18 23:10 ` [PATCH 4/5] watchdog: cleanup a bit omap_wdt.c Russell King - ARM Linux
2008-09-18 23:18 ` Felipe Balbi [this message]
2008-09-18 23:10 ` [PATCH 3/5] watchdog: move omap_wdt.h to include/linux/watchdog Russell King - ARM Linux
2008-09-18 23:14 ` Felipe Balbi
2008-09-18 23:06 ` [PATCH 2/5] watchdog: another ioremap() fix Russell King - ARM Linux
2008-09-18 23:12 ` Felipe Balbi
2008-09-18 23:05 ` [PATCH 1/5] watchdog: sync linux-omap changes Russell King - ARM Linux
2008-09-18 23:11 ` Felipe Balbi
2008-09-18 23:20 ` Russell King - ARM Linux
2008-09-19 8:43 ` Wim Van Sebroeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080918231831.GL6617@frodo \
--to=me@felipebalbi.com \
--cc=david-b@pacbell.net \
--cc=felipe.balbi@nokia.com \
--cc=gdavis@mvista.com \
--cc=linux-omap@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=tony@atomide.com \
--cc=wim@iguana.be \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox