From mboxrd@z Thu Jan 1 00:00:00 1970 From: Russell King - ARM Linux Subject: Re: [PATCH 5/5] watchdog: introduce platform_data and remove cpu conditional code Date: Fri, 19 Sep 2008 00:20:06 +0100 Message-ID: <20080918232006.GJ14307@flint.arm.linux.org.uk> References: <1221776622-22906-1-git-send-email-me@felipebalbi.com> <1221776622-22906-2-git-send-email-me@felipebalbi.com> <1221776622-22906-3-git-send-email-me@felipebalbi.com> <1221776622-22906-4-git-send-email-me@felipebalbi.com> <1221776622-22906-5-git-send-email-me@felipebalbi.com> <1221776622-22906-6-git-send-email-me@felipebalbi.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from caramon.arm.linux.org.uk ([78.32.30.218]:45405 "EHLO caramon.arm.linux.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754235AbYIRXUX (ORCPT ); Thu, 18 Sep 2008 19:20:23 -0400 Content-Disposition: inline In-Reply-To: <1221776622-22906-6-git-send-email-me@felipebalbi.com> Sender: linux-omap-owner@vger.kernel.org List-Id: linux-omap@vger.kernel.org To: Felipe Balbi Cc: linux-omap@vger.kernel.org, Tony Lindgren , David Brownell , "George G. Davis" , Wim Van Sebroeck , Felipe Balbi On Fri, Sep 19, 2008 at 01:23:42AM +0300, Felipe Balbi wrote: > +struct omap_wdt_platform_data { > + const char *ick; > + const char *fck; Grumble. The clk API is supposed to make this stuff completely unnecessary - but OMAP doesn't implement the clk API correctly - by using the 'name' as the sole key. The 'name' argument is supposed to be used to disambiguate between multiple clock inputs on a single device. ;(