Linux on ARM based TI OMAP SoCs
 help / color / mirror / Atom feed
From: Evgeniy Polyakov <johnpol@2ka.mipt.ru>
To: Felipe Balbi <felipe.balbi@nokia.com>
Cc: ext Madhusudhan Chikkature <madhu.cr@ti.com>,
	tony@atomide.com, linux-omap@vger.kernel.org
Subject: Re: [PATCH]OMAP HDQ driver ioremap changes
Date: Tue, 23 Sep 2008 00:14:00 +0400	[thread overview]
Message-ID: <20080922201400.GA25509@2ka.mipt.ru> (raw)
In-Reply-To: <20080922143741.GV24627@gandalf.research.nokia.com>

On Mon, Sep 22, 2008 at 05:37:41PM +0300, Felipe Balbi (felipe.balbi@nokia.com) wrote:
> +/*
> + * Used to control the call to omap_hdq_get and omap_hdq_put.
> + * HDQ Protocol: Write the CMD|REG_address first, followed by
> + * the data wrire or read.
> + */
> +static int init_trans;

This variable is not protected against simultaneous master's access
afaics, isn't it possible to have multiple w1 masters on given board?

-- 
	Evgeniy Polyakov

  reply	other threads:[~2008-09-22 20:14 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-09-22 10:15 [PATCH]OMAP HDQ driver ioremap changes Madhusudhan Chikkature
2008-09-22 13:06 ` Evgeniy Polyakov
2008-09-22 13:13   ` Madhusudhan Chikkature
2008-09-22 13:27     ` Felipe Balbi
2008-09-22 13:31       ` Madhusudhan Chikkature
2008-09-22 13:38         ` Felipe Balbi
2008-09-22 14:37         ` Felipe Balbi
2008-09-22 20:14           ` Evgeniy Polyakov [this message]
2008-09-23  2:24             ` Felipe Balbi
2008-09-23  4:52               ` Madhusudhan Chikkature
2008-09-23  6:52                 ` Evgeniy Polyakov
2008-09-23  4:37           ` Madhusudhan Chikkature
2008-09-23 10:57             ` Felipe Balbi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080922201400.GA25509@2ka.mipt.ru \
    --to=johnpol@2ka.mipt.ru \
    --cc=felipe.balbi@nokia.com \
    --cc=linux-omap@vger.kernel.org \
    --cc=madhu.cr@ti.com \
    --cc=tony@atomide.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox