From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tony Lindgren Subject: Re: [PATCH] Temporary fix to boot OMAP1 based boards Date: Wed, 24 Sep 2008 11:06:53 +0300 Message-ID: <20080924080652.GG5222@atomide.com> References: <20080924.065137.142952786.Hiroshi.DOYU@nokia.com> <20080924071201.GE5222@atomide.com> <20080924075959.GF5222@atomide.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from mho-01-bos.mailhop.org ([63.208.196.178]:62650 "EHLO mho-01-bos.mailhop.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751097AbYIXIG7 (ORCPT ); Wed, 24 Sep 2008 04:06:59 -0400 Content-Disposition: inline In-Reply-To: Sender: linux-omap-owner@vger.kernel.org List-Id: linux-omap@vger.kernel.org To: Paul Walmsley Cc: Arun KS , Hiroshi DOYU , linux-omap@vger.kernel.org * Paul Walmsley [080924 11:03]: > On Wed, 24 Sep 2008, Tony Lindgren wrote: > > > * Tony Lindgren [080924 10:12]: > > > * Arun KS [080924 10:05]: > > > > On Wed, Sep 24, 2008 at 9:21 AM, Hiroshi DOYU wrote: > > > > > Hi, > > > > > > > > > > How about introducing a new typedef in order to accommodate the > > > > > different size of enable_regs without ifdefs? > > > > > > > > > > I think that this is apparently the case categorized into (a) in > > > > > 'CodyingStyle'. > > > > > > > > I am not sure which is the right way to do. Is this what you meant? > > > > > > No, let's not do this. It should be void __iomem * for sure. Most of > > > the omap1 clock registers looks just fine for void __iomem *, let's > > > figure out which registers are broken. > > > > I've pushed a fix for this. Turns out I missed some conversions to > > void __iomem * while merging code from arm-devel branch. Fix also > > attached. > > Those registers should be u16 for OMAP2/3. OMAP1 needs something similar, > which will also get rid of those casts to void __iomem * - hacking on > something now ... Argh, sorry. Yeah it's an offset for omap2/3.. Will revert immediately. Tony