From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tony Lindgren Subject: Re: [PATCH] OMAP3EVM: TWL4030 Keypad irq error fix Date: Wed, 24 Sep 2008 14:25:15 +0300 Message-ID: <20080924112514.GN5222@atomide.com> References: <20080923110001.GL5102@atomide.com> <102CAAD1-D554-4CAD-B26F-DBFB2C418E9A@student.utwente.nl> <200809231245.42614.david-b@pacbell.net> <20080924104431.GL24627@gandalf.research.nokia.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from mho-01-bos.mailhop.org ([63.208.196.178]:50625 "EHLO mho-01-bos.mailhop.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751517AbYIXLZW (ORCPT ); Wed, 24 Sep 2008 07:25:22 -0400 Content-Disposition: inline In-Reply-To: <20080924104431.GL24627@gandalf.research.nokia.com> Sender: linux-omap-owner@vger.kernel.org List-Id: linux-omap@vger.kernel.org To: Felipe Balbi Cc: ext David Brownell , Koen Kooi , "linux-omap@vger.kernel.org List" * Felipe Balbi [080924 13:45]: > On Tue, Sep 23, 2008 at 12:45:42PM -0700, David Brownell wrote: > > On Tuesday 23 September 2008, Koen Kooi wrote: > > > >> > > > >> The clean fix requires twl4030 to be a "new style" driver. > > > >> Fix not yet available. :( > > > > > > > > Pushing until we have a better fix. > > > > > > But twl4030 now is a "new style" driver, so we have a start :) > > > > But who's working on it? :) > > > > Sketch of solution: > > > > - twl4030.h defines keypad platform_data > > > > - add_children() adds a platform device for keypad, > > and passes that platform_data > > > > - twl4030 keypad driver switches to platform_bus > > and uses that platform_data > > > > - board-specific init code provides the relevant > > platform_data (or none) > > > > I'll do the GPIO code, which will be a slightly more > > interesting example than the RTC. > > I can do the keypad since I'm already working on the usb as well. Dave, > I'm gonna add twl_has_rtc(), twl_had_keypad() and twl_has_usb() to clean > a bit add_children. With those, we're gonna be able to: > > if (twl_has_keypad() && pdata->keypad) { > ... > } Meanwhile I'll put together some patches for Jean to sync i2c_omap.c. Tony