Re: [PATCH] OMAP3EVM: TWL4030 Keypad irq error fix

[Felipe Balbi <me@felipebalbi.com>]

On Wed, Sep 24, 2008 at 08:34:16AM -0700, David Brownell wrote:
> On Wednesday 24 September 2008, Felipe Balbi wrote:
> > 
> > > I'll do the GPIO code, which will be a slightly more
> > > interesting example than the RTC.
> > 
> > I can do the keypad since I'm already working on the usb as well.
> 
> OK.  Good to know folk are actively working on getting
> this in shape for upstream!
> 
> 
> > Dave, 
> > I'm gonna add twl_has_rtc(), twl_had_keypad() and twl_has_usb() to clean
> > a bit add_children. With those, we're gonna be able to:
> > 
> > if (twl_has_keypad() && pdata->keypad) {
> >         ...
> > }
> 
> Sounds good.  Fault handling might need attention too.

Sure, think I was thinking that in case in run out of memory I'm gonna
stop trying to add any more children but leaving the ones we could
create up and running. What do you think ?

-- 
balbi
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html