[PATCH] OMAP3EVM: TWL4030 Keypad irq error fix

[PATCH] OMAP3EVM: TWL4030 Keypad irq error fix

[arun c]

without this the below error messages were coming continuously

TWL4030 module irq 369 is disabled but can't be masked!
<2>TWL4030 module irq 369 is disabled but can't be masked!

Signed-off-by: Arun C <arunedarath@mistralsolutions.com>
---
 arch/arm/mach-omap2/board-omap3evm.c |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)

diff --git a/arch/arm/mach-omap2/board-omap3evm.c
b/arch/arm/mach-omap2/board-omap3evm.c
index 92f70ce..f9fd06b 100644
--- a/arch/arm/mach-omap2/board-omap3evm.c
+++ b/arch/arm/mach-omap2/board-omap3evm.c
@@ -22,6 +22,7 @@
 #include <linux/input.h>
 #include <linux/spi/spi.h>
 #include <linux/spi/ads7846.h>
+#include <linux/i2c/twl4030.h>

 #include <mach/hardware.h>
 #include <asm/mach-types.h>
@@ -176,6 +177,7 @@ static struct omap_kp_platform_data omap3evm_kp_data = {
 	.keymap 	= omap3evm_keymap,
 	.keymapsize	= ARRAY_SIZE(omap3evm_keymap),
 	.rep		= 1,
+	.irq		= TWL4030_MODIRQ_KEYPAD,
 };

 static struct platform_device omap3evm_kp_device = {
-- 
1.5.3.4

Re: [PATCH] OMAP3EVM: TWL4030 Keypad irq error fix

[Felipe Balbi]

On Sat, Sep 20, 2008 at 02:51:40AM -0400, arun c wrote:
> without this the below error messages were coming continuously
> 
> TWL4030 module irq 369 is disabled but can't be masked!
> <2>TWL4030 module irq 369 is disabled but can't be masked!
> 
> Signed-off-by: Arun C <arunedarath@mistralsolutions.com>

Acked-by: Felipe Balbi <felipe.balbi@nokia.com>

> ---
>  arch/arm/mach-omap2/board-omap3evm.c |    2 ++
>  1 files changed, 2 insertions(+), 0 deletions(-)
> 
> diff --git a/arch/arm/mach-omap2/board-omap3evm.c
> b/arch/arm/mach-omap2/board-omap3evm.c
> index 92f70ce..f9fd06b 100644
> --- a/arch/arm/mach-omap2/board-omap3evm.c
> +++ b/arch/arm/mach-omap2/board-omap3evm.c
> @@ -22,6 +22,7 @@
>  #include <linux/input.h>
>  #include <linux/spi/spi.h>
>  #include <linux/spi/ads7846.h>
> +#include <linux/i2c/twl4030.h>
> 
>  #include <mach/hardware.h>
>  #include <asm/mach-types.h>
> @@ -176,6 +177,7 @@ static struct omap_kp_platform_data omap3evm_kp_data = {
>  	.keymap 	= omap3evm_keymap,
>  	.keymapsize	= ARRAY_SIZE(omap3evm_keymap),
>  	.rep		= 1,
> +	.irq		= TWL4030_MODIRQ_KEYPAD,
>  };
> 
>  static struct platform_device omap3evm_kp_device = {
> -- 
> 1.5.3.4
> --
> To unsubscribe from this list: send the line "unsubscribe linux-omap" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

-- 
balbi

Re: [PATCH] OMAP3EVM: TWL4030 Keypad irq error fix

[David Brownell]

On Friday 19 September 2008, arun c wrote:
> without this the below error messages were coming continuously
> 
> TWL4030 module irq 369 is disabled but can't be masked!

I can see how it would fix that.  :)

But this is also a good illustration of why this keypad device
should be initialized differently ... this particular data is
not board-specific, and the root cause of the problem was that
the device wasn't set up as part of twl4030 setup.

The clean fix requires twl4030 to be a "new style" driver.
Fix not yet available. :(

- Dave


> Signed-off-by: Arun C <arunedarath@mistralsolutions.com>
> ---
>  arch/arm/mach-omap2/board-omap3evm.c |    2 ++
>  1 files changed, 2 insertions(+), 0 deletions(-)
> 
> diff --git a/arch/arm/mach-omap2/board-omap3evm.c
> b/arch/arm/mach-omap2/board-omap3evm.c
> index 92f70ce..f9fd06b 100644
> --- a/arch/arm/mach-omap2/board-omap3evm.c
> +++ b/arch/arm/mach-omap2/board-omap3evm.c
> @@ -22,6 +22,7 @@
>  #include <linux/input.h>
>  #include <linux/spi/spi.h>
>  #include <linux/spi/ads7846.h>
> +#include <linux/i2c/twl4030.h>
> 
>  #include <mach/hardware.h>
>  #include <asm/mach-types.h>
> @@ -176,6 +177,7 @@ static struct omap_kp_platform_data omap3evm_kp_data = {
>  	.keymap 	= omap3evm_keymap,
>  	.keymapsize	= ARRAY_SIZE(omap3evm_keymap),
>  	.rep		= 1,
> +	.irq		= TWL4030_MODIRQ_KEYPAD,
>  };
> 
>  static struct platform_device omap3evm_kp_device = {
> -- 

Re: [PATCH] OMAP3EVM: TWL4030 Keypad irq error fix

[Tony Lindgren]

* David Brownell <david-b@pacbell.net> [080920 20:23]:
> On Friday 19 September 2008, arun c wrote:
> > without this the below error messages were coming continuously
> > 
> > TWL4030 module irq 369 is disabled but can't be masked!
> 
> I can see how it would fix that.  :)
> 
> But this is also a good illustration of why this keypad device
> should be initialized differently ... this particular data is
> not board-specific, and the root cause of the problem was that
> the device wasn't set up as part of twl4030 setup.
> 
> The clean fix requires twl4030 to be a "new style" driver.
> Fix not yet available. :(

Pushing until we have a better fix.

Tony

> 
> - Dave
> 
> 
> > Signed-off-by: Arun C <arunedarath@mistralsolutions.com>
> > ---
> >  arch/arm/mach-omap2/board-omap3evm.c |    2 ++
> >  1 files changed, 2 insertions(+), 0 deletions(-)
> > 
> > diff --git a/arch/arm/mach-omap2/board-omap3evm.c
> > b/arch/arm/mach-omap2/board-omap3evm.c
> > index 92f70ce..f9fd06b 100644
> > --- a/arch/arm/mach-omap2/board-omap3evm.c
> > +++ b/arch/arm/mach-omap2/board-omap3evm.c
> > @@ -22,6 +22,7 @@
> >  #include <linux/input.h>
> >  #include <linux/spi/spi.h>
> >  #include <linux/spi/ads7846.h>
> > +#include <linux/i2c/twl4030.h>
> > 
> >  #include <mach/hardware.h>
> >  #include <asm/mach-types.h>
> > @@ -176,6 +177,7 @@ static struct omap_kp_platform_data omap3evm_kp_data = {
> >  	.keymap 	= omap3evm_keymap,
> >  	.keymapsize	= ARRAY_SIZE(omap3evm_keymap),
> >  	.rep		= 1,
> > +	.irq		= TWL4030_MODIRQ_KEYPAD,
> >  };
> > 
> >  static struct platform_device omap3evm_kp_device = {
> > -- 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-omap" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] OMAP3EVM: TWL4030 Keypad irq error fix

[Koen Kooi]

[-- Attachment #1: Type: text/plain, Size: 2190 bytes --]


Op 23 sep 2008, om 13:00 heeft Tony Lindgren het volgende geschreven:

> * David Brownell <david-b@pacbell.net> [080920 20:23]:
>> On Friday 19 September 2008, arun c wrote:
>>> without this the below error messages were coming continuously
>>>
>>> TWL4030 module irq 369 is disabled but can't be masked!
>>
>> I can see how it would fix that.  :)
>>
>> But this is also a good illustration of why this keypad device
>> should be initialized differently ... this particular data is
>> not board-specific, and the root cause of the problem was that
>> the device wasn't set up as part of twl4030 setup.
>>
>> The clean fix requires twl4030 to be a "new style" driver.
>> Fix not yet available. :(
>
> Pushing until we have a better fix.

But twl4030 now is a "new style" driver, so we have a start :)

regards,

Koen


>
>
> Tony
>
>>
>> - Dave
>>
>>
>>> Signed-off-by: Arun C <arunedarath@mistralsolutions.com>
>>> ---
>>> arch/arm/mach-omap2/board-omap3evm.c |    2 ++
>>> 1 files changed, 2 insertions(+), 0 deletions(-)
>>>
>>> diff --git a/arch/arm/mach-omap2/board-omap3evm.c
>>> b/arch/arm/mach-omap2/board-omap3evm.c
>>> index 92f70ce..f9fd06b 100644
>>> --- a/arch/arm/mach-omap2/board-omap3evm.c
>>> +++ b/arch/arm/mach-omap2/board-omap3evm.c
>>> @@ -22,6 +22,7 @@
>>> #include <linux/input.h>
>>> #include <linux/spi/spi.h>
>>> #include <linux/spi/ads7846.h>
>>> +#include <linux/i2c/twl4030.h>
>>>
>>> #include <mach/hardware.h>
>>> #include <asm/mach-types.h>
>>> @@ -176,6 +177,7 @@ static struct omap_kp_platform_data  
>>> omap3evm_kp_data = {
>>> 	.keymap 	= omap3evm_keymap,
>>> 	.keymapsize	= ARRAY_SIZE(omap3evm_keymap),
>>> 	.rep		= 1,
>>> +	.irq		= TWL4030_MODIRQ_KEYPAD,
>>> };
>>>
>>> static struct platform_device omap3evm_kp_device = {
>>> -- 
>> --
>> To unsubscribe from this list: send the line "unsubscribe linux- 
>> omap" in
>> the body of a message to majordomo@vger.kernel.org
>> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> --
> To unsubscribe from this list: send the line "unsubscribe linux- 
> omap" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>


[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 186 bytes --]

Re: [PATCH] OMAP3EVM: TWL4030 Keypad irq error fix

[David Brownell]

On Tuesday 23 September 2008, Koen Kooi wrote:
> >>
> >> The clean fix requires twl4030 to be a "new style" driver.
> >> Fix not yet available. :(
> >
> > Pushing until we have a better fix.
> 
> But twl4030 now is a "new style" driver, so we have a start :)

But who's working on it?  :)

Sketch of solution:

 - twl4030.h defines keypad platform_data

 - add_children() adds a platform device for keypad,
   and passes that platform_data

 - twl4030 keypad driver switches to platform_bus
   and uses that platform_data

 - board-specific init code provides the relevant
   platform_data (or none)

I'll do the GPIO code, which will be a slightly more
interesting example than the RTC.

Re: [PATCH] OMAP3EVM: TWL4030 Keypad irq error fix

[Felipe Balbi]

On Tue, Sep 23, 2008 at 12:45:42PM -0700, David Brownell wrote:
> On Tuesday 23 September 2008, Koen Kooi wrote:
> > >>
> > >> The clean fix requires twl4030 to be a "new style" driver.
> > >> Fix not yet available. :(
> > >
> > > Pushing until we have a better fix.
> > 
> > But twl4030 now is a "new style" driver, so we have a start :)
> 
> But who's working on it?  :)
> 
> Sketch of solution:
> 
>  - twl4030.h defines keypad platform_data
> 
>  - add_children() adds a platform device for keypad,
>    and passes that platform_data
> 
>  - twl4030 keypad driver switches to platform_bus
>    and uses that platform_data
> 
>  - board-specific init code provides the relevant
>    platform_data (or none)
> 
> I'll do the GPIO code, which will be a slightly more
> interesting example than the RTC.

I can do the keypad since I'm already working on the usb as well. Dave,
I'm gonna add twl_has_rtc(), twl_had_keypad() and twl_has_usb() to clean
a bit add_children. With those, we're gonna be able to:

if (twl_has_keypad() && pdata->keypad) {
	...
}

-- 
balbi

Re: [PATCH] OMAP3EVM: TWL4030 Keypad irq error fix

[Tony Lindgren]

* Felipe Balbi <felipe.balbi@nokia.com> [080924 13:45]:
> On Tue, Sep 23, 2008 at 12:45:42PM -0700, David Brownell wrote:
> > On Tuesday 23 September 2008, Koen Kooi wrote:
> > > >>
> > > >> The clean fix requires twl4030 to be a "new style" driver.
> > > >> Fix not yet available. :(
> > > >
> > > > Pushing until we have a better fix.
> > > 
> > > But twl4030 now is a "new style" driver, so we have a start :)
> > 
> > But who's working on it?  :)
> > 
> > Sketch of solution:
> > 
> >  - twl4030.h defines keypad platform_data
> > 
> >  - add_children() adds a platform device for keypad,
> >    and passes that platform_data
> > 
> >  - twl4030 keypad driver switches to platform_bus
> >    and uses that platform_data
> > 
> >  - board-specific init code provides the relevant
> >    platform_data (or none)
> > 
> > I'll do the GPIO code, which will be a slightly more
> > interesting example than the RTC.
> 
> I can do the keypad since I'm already working on the usb as well. Dave,
> I'm gonna add twl_has_rtc(), twl_had_keypad() and twl_has_usb() to clean
> a bit add_children. With those, we're gonna be able to:
> 
> if (twl_has_keypad() && pdata->keypad) {
> 	...
> }

Meanwhile I'll put together some patches for Jean to sync i2c_omap.c.

Tony

Re: [PATCH] OMAP3EVM: TWL4030 Keypad irq error fix

[David Brownell]

On Wednesday 24 September 2008, Felipe Balbi wrote:
> 
> > I'll do the GPIO code, which will be a slightly more
> > interesting example than the RTC.
> 
> I can do the keypad since I'm already working on the usb as well.

OK.  Good to know folk are actively working on getting
this in shape for upstream!


> Dave, 
> I'm gonna add twl_has_rtc(), twl_had_keypad() and twl_has_usb() to clean
> a bit add_children. With those, we're gonna be able to:
> 
> if (twl_has_keypad() && pdata->keypad) {
>         ...
> }

Sounds good.  Fault handling might need attention too.

- Dave

--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] OMAP3EVM: TWL4030 Keypad irq error fix

[Felipe Balbi]

On Wed, Sep 24, 2008 at 08:34:16AM -0700, David Brownell wrote:
> On Wednesday 24 September 2008, Felipe Balbi wrote:
> > 
> > > I'll do the GPIO code, which will be a slightly more
> > > interesting example than the RTC.
> > 
> > I can do the keypad since I'm already working on the usb as well.
> 
> OK.  Good to know folk are actively working on getting
> this in shape for upstream!
> 
> 
> > Dave, 
> > I'm gonna add twl_has_rtc(), twl_had_keypad() and twl_has_usb() to clean
> > a bit add_children. With those, we're gonna be able to:
> > 
> > if (twl_has_keypad() && pdata->keypad) {
> >         ...
> > }
> 
> Sounds good.  Fault handling might need attention too.

Sure, think I was thinking that in case in run out of memory I'm gonna
stop trying to add any more children but leaving the ones we could
create up and running. What do you think ?

-- 
balbi
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] OMAP3EVM: TWL4030 Keypad irq error fix

[David Brownell]

On Wednesday 24 September 2008, Felipe Balbi wrote:
> 
> > > if (twl_has_keypad() && pdata->keypad) {
> > >         ...
> > > }
> > 
> > Sounds good.  Fault handling might need attention too.
> 
> Sure, think I was thinking that in case in run out of memory I'm gonna
> stop trying to add any more children but leaving the ones we could
> create up and running. What do you think ?

Pretty much my conclusion:  report the problem, but continue.
In fact there's no point in returning error codes from that
routine...

--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html