public inbox for linux-omap@vger.kernel.org
 help / color / mirror / Atom feed
From: Tony Lindgren <tony@atomide.com>
To: Koen Kooi <k.kooi@student.utwente.nl>
Cc: "linux-omap@vger.kernel.org List" <linux-omap@vger.kernel.org>
Subject: Re: MMC broken on beagleboard with current git
Date: Thu, 25 Sep 2008 13:39:53 +0300	[thread overview]
Message-ID: <20080925103952.GJ5222@atomide.com> (raw)
In-Reply-To: <4D346DA2-6C57-48A7-AC4E-2191C44497CF@student.utwente.nl>

* Koen Kooi <k.kooi@student.utwente.nl> [080925 13:25]:
>
> Op 25 sep 2008, om 11:47 heeft Tony Lindgren het volgende geschreven:
>
>> * Koen Kooi <k.kooi@student.utwente.nl> [080925 12:23]:
>>>
>>> Op 25 sep 2008, om 10:51 heeft Tony Lindgren het volgende geschreven:
>>>
>>>> * Koen Kooi <k.kooi@student.utwente.nl> [080925 11:42]:
>>>>> Hi,
>>>>>
>>>>> I just built a kernel from current git[1] and the mmc controller
>>>>> doesn't
>>>>> get detected on boot on my beagleboards. The omap mmc system has
>>>>> seen a
>>>>> lot of changes lately, does anyone have a hint where to start  
>>>>> looking
>>>>> before attemping a bisect?
>>>>
>>>> Sounds like the recent mmc init changes we've done:
>>>>
>>>> 535e1808d1c77a580815f7d7daacc6c030e29cb1 -  12 september 2008
>>>
>>>> 8e6e06c71b9d21d85a3ae652868e2802c054a08a - 12 september 2008
>>>
>>>> c434c15d28c82d92e55897bd265c423e9ab69362 - 24 september 2008
>>>
>>>
>>>> I've verified that it works on omap3430sdp. But mach-omap2/hsmmc.c
>>>> needs
>>>> some more work done to support other mmc controllers besides the  
>>>> first
>>>> one.
>>>> I don't think other controllers ever worked before these patches
>>>> either though..
>>>>
>>>> Let me know if you can narrow it down to some commit and I may be  
>>>> able
>>>> to help further from there.
>>>
>>> The previous working version I built was based of
>>> de1121fdb899f762b9e717f44eaf3fae7c00cd3e which was commited at 13
>>> september 2008, so 535e18.. and 8e6e06c.. don't break it.
>>
>> OK, good to know. Can you try to git-bisect it?
>
> That proved to be a lot less work than expected :)
>
> Last good: 9d1dff8638c9e96a401e1885f9948662e9ff9636
> First bad: c434c15d28c82d92e55897bd265c423e9ab69362
>
> So 
> http://source.mvista.com/git/gitweb.cgi?p=linux-omap-2.6.git;a=commit;h=c434c15d28c82d92e55897bd265c423e9ab69362 
>  breaks MMC on beagle.

Hmm, I don't understand how it could work on 3430sdp...

Looks like board-omap3beagle.c calls hsmmc_init() just like
board-3430sdp.c. Maybe timings have changed and you need
a longer delay somewhere during the init?

Maybe sprinkle some printks to hsmmc.c and see if that
makes it to work?

Also make sure omap_hsmmc.c probe finishes OK.

Tony

>>>>> [1] http://source.mvista.com/git/gitweb.cgi?p=linux-omap-2.6.git;a=commit;h=c434c15d28c82d92e55897bd265c423e9ab69362




  reply	other threads:[~2008-09-25 10:39 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-09-25  8:41 MMC broken on beagleboard with current git Koen Kooi
2008-09-25  8:51 ` Tony Lindgren
2008-09-25  9:23   ` Koen Kooi
2008-09-25  9:47     ` Tony Lindgren
2008-09-25 10:24       ` Koen Kooi
2008-09-25 10:39         ` Tony Lindgren [this message]
2008-09-25 15:24           ` Steve Sakoman
2008-09-26  7:42             ` Tony Lindgren
2008-09-26 11:13               ` Tony Lindgren
2008-09-28 12:46                 ` Tony Lindgren
2008-09-30 12:58                   ` Tony Lindgren
2008-09-30 13:22                     ` Felipe Balbi
2008-09-30 13:35                       ` Tony Lindgren
2008-09-30 13:43                         ` Felipe Balbi
2008-09-30 13:24                     ` Felipe Contreras

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080925103952.GJ5222@atomide.com \
    --to=tony@atomide.com \
    --cc=k.kooi@student.utwente.nl \
    --cc=linux-omap@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox