[patch 2.6.27-rc6-omap] ASOC: quieter boot for non-Overo boards

[patch 2.6.27-rc6-omap] ASOC: quieter boot for non-Overo boards

[David Brownell]

Get rid of bogus ASOC boot messages on non-Overo boards.

Signed-off-by: David Brownell <dbrownell@users.sourceforge.net>
---
 sound/soc/omap/overo.c |    7 +++----
 1 file changed, 3 insertions(+), 4 deletions(-)

--- a/sound/soc/omap/overo.c
+++ b/sound/soc/omap/overo.c
@@ -107,11 +107,11 @@ static int __init overo_soc_init(void)
 {
 	int ret;
 
-	printk(KERN_INFO "overo SoC init\n");
 	if (!machine_is_overo()) {
-		printk(KERN_ERR "Not Overo!\n");
+		pr_debug("Not Overo!\n");
 		return -ENODEV;
 	}
+	printk(KERN_INFO "overo SoC init\n");
 
 	overo_snd_device = platform_device_alloc("soc-audio", -1);
 	if (!overo_snd_device) {
@@ -135,13 +135,12 @@ err1:
 
 	return ret;
 }
+module_init(overo_soc_init);
 
 static void __exit overo_soc_exit(void)
 {
 	platform_device_unregister(overo_snd_device);
 }
-
-module_init(overo_soc_init);
 module_exit(overo_soc_exit);
 
 MODULE_AUTHOR("Steve Sakoman <steve@sakoman.com>");

Re: [patch 2.6.27-rc6-omap] ASOC: quieter boot for non-Overo boards

[Tony Lindgren]

* David Brownell <david-b@pacbell.net> [080922 00:50]:
> Get rid of bogus ASOC boot messages on non-Overo boards.

I'm not touching this without an ack from alsa list :)

Tony

> 
> Signed-off-by: David Brownell <dbrownell@users.sourceforge.net>
> ---
>  sound/soc/omap/overo.c |    7 +++----
>  1 file changed, 3 insertions(+), 4 deletions(-)
> 
> --- a/sound/soc/omap/overo.c
> +++ b/sound/soc/omap/overo.c
> @@ -107,11 +107,11 @@ static int __init overo_soc_init(void)
>  {
>  	int ret;
>  
> -	printk(KERN_INFO "overo SoC init\n");
>  	if (!machine_is_overo()) {
> -		printk(KERN_ERR "Not Overo!\n");
> +		pr_debug("Not Overo!\n");
>  		return -ENODEV;
>  	}
> +	printk(KERN_INFO "overo SoC init\n");
>  
>  	overo_snd_device = platform_device_alloc("soc-audio", -1);
>  	if (!overo_snd_device) {
> @@ -135,13 +135,12 @@ err1:
>  
>  	return ret;
>  }
> +module_init(overo_soc_init);
>  
>  static void __exit overo_soc_exit(void)
>  {
>  	platform_device_unregister(overo_snd_device);
>  }
> -
> -module_init(overo_soc_init);
>  module_exit(overo_soc_exit);
>  
>  MODULE_AUTHOR("Steve Sakoman <steve@sakoman.com>");
> --
> To unsubscribe from this list: send the line "unsubscribe linux-omap" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [patch 2.6.27-rc6-omap] ASOC: quieter boot for non-Overo boards

[David Brownell]

On Thursday 25 September 2008, Tony Lindgren wrote:
> > Get rid of bogus ASOC boot messages on non-Overo boards.
> 
> I'm not touching this without an ack from alsa list :)

Has this driver even gone to that list yet?  ;)


I haven't really looked at initialization for this yet,
but my initial reaction to seeing the Beagle's version
of the overo.c file is that more sharing should exist.
(Wasn't the beagle ASOC init described as a clone?)

And then ... that, hey, this should hook into the same
MFD-style initialization as we're making the other
twl4030 code use.

And finally ... whoa, maybe someone else can split
out the board-specific bits so they can be put in
the arch/arm/mach-omap2/board-XYZ.c files, since I'd
surely lose a lot of time learning ASOC if I were
to start that!  (These messages are right at the
core of that bit.)

- Dave

Re: [patch 2.6.27-rc6-omap] ASOC: quieter boot for non-Overo boards

[Steve Sakoman]

On Thu, 2008-09-25 at 09:50 -0700, David Brownell wrote:
> On Thursday 25 September 2008, Tony Lindgren wrote:
> > > Get rid of bogus ASOC boot messages on non-Overo boards.
> > 
> > I'm not touching this without an ack from alsa list :)
> 
> Has this driver even gone to that list yet?  ;)

Yes, the initial submission was reviewed and acked by folks on
alsa-devel.

And now that I think of it, this code should never execute on non-overo
boards since they will have their own machine ASoC driver!  So this
patch isn't really necessary.

> I haven't really looked at initialization for this yet,
> but my initial reaction to seeing the Beagle's version
> of the overo.c file is that more sharing should exist.
> (Wasn't the beagle ASOC init described as a clone?)

This was discussed, but since the overo has some additional
functionality that will be added to the machine portion of the driver it
was decided to have separate machine files for overo and beagle.  I'm
waiting for an overo "buddy" board that brings out the additional
microphone inputs before I can add and test this functionality.

> And then ... that, hey, this should hook into the same
> MFD-style initialization as we're making the other
> twl4030 code use.
> 
> And finally ... whoa, maybe someone else can split
> out the board-specific bits so they can be put in
> the arch/arm/mach-omap2/board-XYZ.c files, since I'd
> surely lose a lot of time learning ASOC if I were
> to start that!  (These messages are right at the
> core of that bit.)

Putting the board specific bits in the arch/arm/mach-omap2/board-XYZ.c
file has been discussed a number of times on alsa-devel and the folks
there insist that for now (i.e. ASoC V1) this is the proper way to do
things.

Steve

Re: [patch 2.6.27-rc6-omap] ASOC: quieter boot for non-Overo boards

[David Brownell]

On Thursday 25 September 2008, Steve Sakoman wrote:
> On Thu, 2008-09-25 at 09:50 -0700, David Brownell wrote:
> > On Thursday 25 September 2008, Tony Lindgren wrote:
> > > > Get rid of bogus ASOC boot messages on non-Overo boards.
> > > 
> > > I'm not touching this without an ack from alsa list :)
> > 
> > Has this driver even gone to that list yet?  ;)
> 
> Yes, the initial submission was reviewed and acked by folks on
> alsa-devel.
> 
> And now that I think of it, this code should never execute on non-overo
> boards since they will have their own machine ASoC driver!  So this
> patch isn't really necessary.

But it *did* execute on a Beagle.  The kernel had both
Overo and Beagle configured in.

Ergo the $SUBJECT patch.  :)


> > I haven't really looked at initialization for this yet,
> > but my initial reaction to seeing the Beagle's version
> > of the overo.c file is that more sharing should exist.
> > (Wasn't the beagle ASOC init described as a clone?)
> 
> This was discussed, but since the overo has some additional
> functionality that will be added to the machine portion of the driver it
> was decided to have separate machine files for overo and beagle.  I'm
> waiting for an overo "buddy" board that brings out the additional
> microphone inputs before I can add and test this functionality.

OK.  The amount of code isn't actually that much, but
what's there looks like it should be sharable.


> > And then ... that, hey, this should hook into the same
> > MFD-style initialization as we're making the other
> > twl4030 code use.
> > 
> > And finally ... whoa, maybe someone else can split
> > out the board-specific bits so they can be put in
> > the arch/arm/mach-omap2/board-XYZ.c files, since I'd
> > surely lose a lot of time learning ASOC if I were
> > to start that!  (These messages are right at the
> > core of that bit.)
> 
> Putting the board specific bits in the arch/arm/mach-omap2/board-XYZ.c
> file has been discussed a number of times on alsa-devel and the folks
> there insist that for now (i.e. ASoC V1) this is the proper way to do
> things.

Hmm, I'm not sure I follow.  They want the SOC devices
in the wrong place in the driver model tree, potentially
impacting power management?

I don't want to fight that fight, but ... that seems unwise.

- Dave

Re: [patch 2.6.27-rc6-omap] ASOC: quieter boot for non-Overo boards

[Jarkko Nikula]

On Thu, 25 Sep 2008 10:41:48 -0700
"ext David Brownell" <david-b@pacbell.net> wrote:

> > Putting the board specific bits in the
> > arch/arm/mach-omap2/board-XYZ.c file has been discussed a number of
> > times on alsa-devel and the folks there insist that for now (i.e.
> > ASoC V1) this is the proper way to do things.
> 
> Hmm, I'm not sure I follow.  They want the SOC devices
> in the wrong place in the driver model tree, potentially
> impacting power management?
> 
> I don't want to fight that fight, but ... that seems unwise.
> 
Yep. Now in ASoC v1, the machine, platform/CPU and codec are tied
together during compile time and I think it has been easier to
review/manage by keeping them under one sound/soc directory.

I suppose that when ASoC v2 is in place and devices can be individually
probed, we might see that machine drivers will start moving out from
there.


Jarkko