From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tony Lindgren Subject: Re: [PATCH] Fixed OMAP3 version check Date: Thu, 25 Sep 2008 14:49:32 +0300 Message-ID: <20080925114932.GP5222@atomide.com> References: <1221572797-15949-1-git-send-email-tero.kristo@nokia.com> <1221572797-15949-2-git-send-email-tero.kristo@nokia.com> <20080925101750.GG5222@atomide.com> <20080925102331.GC24627@gandalf.research.nokia.com> <20080925103120.GI5222@atomide.com> <20080925114117.GD24627@gandalf.research.nokia.com> <20080925114731.GO5222@atomide.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from mho-01-bos.mailhop.org ([63.208.196.178]:64355 "EHLO mho-01-bos.mailhop.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753223AbYIYLtf (ORCPT ); Thu, 25 Sep 2008 07:49:35 -0400 Content-Disposition: inline In-Reply-To: <20080925114731.GO5222@atomide.com> Sender: linux-omap-owner@vger.kernel.org List-Id: linux-omap@vger.kernel.org To: Tero.Kristo@nokia.com Cc: felipe.balbi@nokia.com, linux-omap@vger.kernel.org * Tony Lindgren [080925 14:47]: > * Tero.Kristo@nokia.com [080925 14:45]: > > > > > > >-----Original Message----- > > >From: Balbi Felipe (Nokia-D/Helsinki) > > >Sent: 25 September, 2008 14:41 > > >To: ext Tony Lindgren > > >Cc: Balbi Felipe (Nokia-D/Helsinki); Kristo Tero > > >(Nokia-D/Tampere); linux-omap@vger.kernel.org > > >Subject: Re: [PATCH] Fixed OMAP3 version check > > > > > >On Thu, Sep 25, 2008 at 01:31:21PM +0300, Tony Lindgren wrote: > > >> * Felipe Balbi [080925 13:24]: > > >> > On Thu, Sep 25, 2008 at 01:17:51PM +0300, Tony Lindgren wrote: > > >> > > Hi, > > >> > > > > >> > > * Tero Kristo [080916 14:59]: > > >> > > > CPU version was reported incorrectly (e.g. ES3.0 instead of > > >> > > > ES2.1.) Also added a piece of optimization for CPU > > >type check (omap_type()). > > >> > > > > > >> > > > Signed-off-by: Tero Kristo > > >> > > > --- > > >> > > > arch/arm/mach-omap2/id.c | 7 +++++-- > > >> > > > 1 files changed, 5 insertions(+), 2 deletions(-) > > >> > > > > > >> > > > diff --git a/arch/arm/mach-omap2/id.c > > >b/arch/arm/mach-omap2/id.c > > >> > > > index ab7a6e9..4e2b449 100644 > > >> > > > --- a/arch/arm/mach-omap2/id.c > > >> > > > +++ b/arch/arm/mach-omap2/id.c > > >> > > > @@ -37,7 +37,10 @@ EXPORT_SYMBOL(omap_chip_is); > > >> > > > > > >> > > > int omap_type(void) > > >> > > > { > > >> > > > - u32 val = 0; > > >> > > > + static u32 val; > > >> > > > + > > >> > > > + if (val != 0) > > >> > > > + return val; > > >> > > > > >> > > Hmm I guess this would return a random val? :) > > >> > > > >> > it would return 0, look that val is static. > > >> > > >> Ah, sorry I did not see the static. So this is to cache the > > >result to > > >> optimize it? I'd assume this function is only needed during > > >some init > > >> code hopefully where performance does not matter.. > > > > > >Yeah, it's not like we're gonna check the revision after the > > >board is botted all up I guess. > > > > PM code will need to either cache the type information or call this > > check every time when entering off-mode. Some things work differently in > > secure chips. Could probably just cache this inside PM code. > > How about setting up the save and restore registers properly for GP > and HS omap once during PM init? To clarify: Set the save and restore registers and needed functions only once during PM init depending on the omap type. Tony