public inbox for linux-omap@vger.kernel.org
 help / color / mirror / Atom feed
* [patch 2.6.27-rc6-omap] hsmmc: request_irq says which controller is involved
@ 2008-09-21 21:16 David Brownell
  2008-09-25 12:50 ` Tony Lindgren
  0 siblings, 1 reply; 2+ messages in thread
From: David Brownell @ 2008-09-21 21:16 UTC (permalink / raw)
  To: linux-omap

Make the hsmmc driver irq requests say which controller they're
associated with (e.g. "mmc0") so /proc/interrupts is more useful.

Signed-off-by: David Brownell <dbrownell@users.sourceforge.net>

--- a/drivers/mmc/host/omap_hsmmc.c
+++ b/drivers/mmc/host/omap_hsmmc.c
@@ -908,8 +908,8 @@ static int __init omap_mmc_probe(struct platform_device *pdev)
 			OMAP_HSMMC_READ(host->base, HCTL) | SDBP);
 
 	/* Request IRQ for MMC operations */
-	ret = request_irq(host->irq, mmc_omap_irq, IRQF_DISABLED, pdev->name,
-			 host);
+	ret = request_irq(host->irq, mmc_omap_irq, IRQF_DISABLED,
+			mmc_hostname(mmc), host);
 	if (ret) {
 		dev_dbg(mmc_dev(host->mmc), "Unable to grab HSMMC IRQ\n");
 		goto err_irq;
@@ -918,8 +918,8 @@ static int __init omap_mmc_probe(struct platform_device *pdev)
 	/* Request IRQ for card detect */
 	if ((mmc_slot(host).card_detect_irq) && (mmc_slot(host).card_detect)) {
 		ret = request_irq(mmc_slot(host).card_detect_irq,
-				  omap_mmc_cd_handler, IRQF_DISABLED, "MMC CD",
-				  host);
+				  omap_mmc_cd_handler, IRQF_DISABLED,
+				  mmc_hostname(mmc), host);
 		if (ret) {
 			dev_dbg(mmc_dev(host->mmc),
 				"Unable to grab MMC CD IRQ\n");

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [patch 2.6.27-rc6-omap] hsmmc: request_irq says which controller is involved
  2008-09-21 21:16 [patch 2.6.27-rc6-omap] hsmmc: request_irq says which controller is involved David Brownell
@ 2008-09-25 12:50 ` Tony Lindgren
  0 siblings, 0 replies; 2+ messages in thread
From: Tony Lindgren @ 2008-09-25 12:50 UTC (permalink / raw)
  To: David Brownell; +Cc: linux-omap

* David Brownell <david-b@pacbell.net> [080922 00:50]:
> Make the hsmmc driver irq requests say which controller they're
> associated with (e.g. "mmc0") so /proc/interrupts is more useful.

Pushing today.

Tony

> 
> Signed-off-by: David Brownell <dbrownell@users.sourceforge.net>
> 
> --- a/drivers/mmc/host/omap_hsmmc.c
> +++ b/drivers/mmc/host/omap_hsmmc.c
> @@ -908,8 +908,8 @@ static int __init omap_mmc_probe(struct platform_device *pdev)
>  			OMAP_HSMMC_READ(host->base, HCTL) | SDBP);
>  
>  	/* Request IRQ for MMC operations */
> -	ret = request_irq(host->irq, mmc_omap_irq, IRQF_DISABLED, pdev->name,
> -			 host);
> +	ret = request_irq(host->irq, mmc_omap_irq, IRQF_DISABLED,
> +			mmc_hostname(mmc), host);
>  	if (ret) {
>  		dev_dbg(mmc_dev(host->mmc), "Unable to grab HSMMC IRQ\n");
>  		goto err_irq;
> @@ -918,8 +918,8 @@ static int __init omap_mmc_probe(struct platform_device *pdev)
>  	/* Request IRQ for card detect */
>  	if ((mmc_slot(host).card_detect_irq) && (mmc_slot(host).card_detect)) {
>  		ret = request_irq(mmc_slot(host).card_detect_irq,
> -				  omap_mmc_cd_handler, IRQF_DISABLED, "MMC CD",
> -				  host);
> +				  omap_mmc_cd_handler, IRQF_DISABLED,
> +				  mmc_hostname(mmc), host);
>  		if (ret) {
>  			dev_dbg(mmc_dev(host->mmc),
>  				"Unable to grab MMC CD IRQ\n");
> --
> To unsubscribe from this list: send the line "unsubscribe linux-omap" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2008-09-25 12:50 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-09-21 21:16 [patch 2.6.27-rc6-omap] hsmmc: request_irq says which controller is involved David Brownell
2008-09-25 12:50 ` Tony Lindgren

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox