From: Felipe Balbi <me@felipebalbi.com>
To: "Gadiyar, Anand" <gadiyar@ti.com>
Cc: "linux-omap@vger.kernel.org" <linux-omap@vger.kernel.org>,
"felipe.balbi@nokia.com" <felipe.balbi@nokia.com>
Subject: Re: [PATCH] watchdog: fix typo in omap_wdt.c
Date: Fri, 26 Sep 2008 20:52:38 +0300 [thread overview]
Message-ID: <20080926175237.GD9890@frodo> (raw)
In-Reply-To: <5A47E75E594F054BAF48C5E4FC4B92AB02D5DC959A@dbde02.ent.ti.com>
On Fri, Sep 26, 2008 at 09:20:14PM +0530, Gadiyar, Anand wrote:
> From: Anand Gadiyar <gadiyar@ti.com>
>
> Fix typo in omap_wdt.c introduced by a recent change
>
> Signed-off-by: Anand Gadiyar <gadiyar@ti.com>
> ---
> drivers/watchdog/omap_wdt.c | 2 +-
> 1 files changed, 1 insertion(+), 1 deletion(-)
>
> Index: tony/drivers/watchdog/omap_wdt.c
> ===================================================================
> --- tony.orig/drivers/watchdog/omap_wdt.c 2008-09-25 16:45:08.000000000 +0530
> +++ tony/drivers/watchdog/omap_wdt.c 2008-09-26 21:14:48.059042569 +0530
> @@ -283,7 +283,7 @@ static int __init omap_wdt_probe(struct
> }
>
> if (omap_wdt_dev) {
> - ret - EBUSY;
> + ret = -EBUSY;
> goto err_busy;
> }
Those patches weren't applied to linux-omap yet, so this change should
be melded into the patch that introduced it. It's better to resend that
patch then to create a messed up bisect line.
--
balbi
next prev parent reply other threads:[~2008-09-26 17:52 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-09-26 15:50 [PATCH] watchdog: fix typo in omap_wdt.c Gadiyar, Anand
2008-09-26 17:52 ` Felipe Balbi [this message]
2008-09-26 18:02 ` Gadiyar, Anand
2008-09-26 19:27 ` Felipe Balbi
2008-09-29 4:26 ` Gadiyar, Anand
2008-09-29 9:25 ` Felipe Balbi
2008-09-29 9:29 ` Gadiyar, Anand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080926175237.GD9890@frodo \
--to=me@felipebalbi.com \
--cc=felipe.balbi@nokia.com \
--cc=gadiyar@ti.com \
--cc=linux-omap@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox