Re: [PATCH 11/9] move twl4030-gpio to drivers/gpio

Felipe Contreras
2008-10-01T13:46:15Z

On Sun, Sep 28, 2008 at 8:16 AM, David Brownell <david-b@pacbell.net> wrote:
> On Saturday 27 September 2008, Felipe Balbi wrote:
>> On Sat, Sep 27, 2008 at 04:45:20PM -0700, David Brownell wrote:
>> > On Saturday 27 September 2008, Felipe Balbi wrote:
>> > > We need something like the patch below (I can't find a substitute
>> > > to twl4030_set_gpio_edge_ctrl and twl4030_set_gpio_debounce):
>> >
>> > Something like that, yes. I have other patches queued up though.
>> >
>> > And meanwhile, your build seems goofed ... fix that first.
>>
>> Yeah, it only happens when both mmc and twl4030-gpio are built as
>> modules. Still sounds weird since we have EXPORT_SYMBOL() for those
>> twl-specific crap.
>
> Don't yet build twl4030 as a module. The vmlinux object can't
> link against symbols in other objects. ;)
>
> As I noted, the modular option is for build testing; when this
> goes to mainline, this code should be able to build on most any
> platform. (Not just OMAP; not just ARM.) I don't think any of
> the OMAP boards which actually use this code will be able to use
> that as a module, though.
>
> When hsmmc.c behaves again, I've got patches to get rid of its
> use of those twl-specific symbols. Then that linkage issue
> will go away.

Hmm, I'm seeing two different configs:
CONFIG_TWL4030_GPIO
CONFIG_GPIO_TWL4030

I guess the defconfigs are wrong.

--
Felipe Contreras