Re: [PATCH 9/9] i2c: move twl4030-madc to new registration style

David Brownell
2008-09-26T17:09:20Z

On Friday 26 September 2008, Felipe Balbi wrote:
>  arch/arm/mach-omap2/board-2430sdp.c     |    6 +
>  arch/arm/mach-omap2/board-3430sdp.c     |    6 +
>  arch/arm/mach-omap2/board-ldp.c         |    6 +
>  arch/arm/mach-omap2/board-omap2evm.c    |    6 +
>  arch/arm/mach-omap2/board-omap3beagle.c |    6 +
>  arch/arm/mach-omap2/board-omap3evm.c    |    6 +
>  arch/arm/mach-omap2/board-overo.c       |    6 +

The MADC stuff gave me:

arch/arm/mach-omap2/board-omap3beagle.c:118: error: 'TWL4030_MADC_IMR1' undeclared here (not in a function)
arch/arm/mach-omap2/board-omap3beagle.c:119: error: 'TWL4030_MADC_ISR1' undeclared here (not in a function)
make[1]: *** [arch/arm/mach-omap2/board-omap3beagle.o] Error 1
make[1]: *** Waiting for unfinished jobs....
make: *** [arch/arm/mach-omap2] Error 2
CC kernel/panic.o

Ditto for Overo.

Passing those registers in platform data seems bizarre.
Doesn't the MADC code know its own register offsets??

The platform data should probably say which ADC channels
are wired up...

And no ADC lines are even hooked up on Beagle, so the right
fix is just to not provide madc platform data on beagle.
Probably the same is true on some other boards.

Plus: MADC is just a set of ADC channels, right?
If so, the driver should have a comment saying that.

- Dave
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html