From: "Peter 'p2' De Schrijver" <peter.de-schrijver@nokia.com>
To: ext David Brownell <david-b@pacbell.net>
Cc: linux-omap@vger.kernel.org
Subject: Re: does twl3040-pwrirq.c "need" to be a separate file?
Date: Tue, 30 Sep 2008 12:22:25 +0300 [thread overview]
Message-ID: <20080930092225.GD4552@codecarver.research.nokia.com> (raw)
In-Reply-To: <200809291417.12437.david-b@pacbell.net>
Hi David,
On Mon, Sep 29, 2008 at 02:17:12PM -0700, ext David Brownell wrote:
> Hi Peter,
>
> I see your patch 68d7477caca19c0b52b5d4e85700cd3e6115577f created
> pwrirq.c as a separate file and thread.
>
I guess choose this solution because it was similar to the GPIO IRQs.
Originally, this was 1 shared IRQ. But I wanted to change this to avoid
every driver having to read PWR_ISR1 and clear his interrupt. This saves
some i2c transactions.
> I'm wondering if there's any particular reason that "bank" of
> interrupts shouldn't be handled directly by twl4030-core, and
> even by the same IRQ handling thread.
>
I don't think so.
> As it stands now the TWL "core" is not especially core-ish in
> this respect, and I'd like to see that be resolved (e.g. by a
> patch I'll probably write this afternoon) before this code
> goes to mainline ...
Ok. Good.
Cheers,
Peter.
--
goa is a state of mind
next prev parent reply other threads:[~2008-09-30 9:23 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-09-29 21:17 does twl3040-pwrirq.c "need" to be a separate file? David Brownell
2008-09-30 9:22 ` Peter 'p2' De Schrijver [this message]
2008-09-30 18:03 ` David Brownell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080930092225.GD4552@codecarver.research.nokia.com \
--to=peter.de-schrijver@nokia.com \
--cc=david-b@pacbell.net \
--cc=linux-omap@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox