From: David Brownell <david-b@pacbell.net>
To: Felipe Balbi <felipe.balbi@nokia.com>
Cc: linux-omap@vger.kernel.org, Tony Lindgren <tony@atomide.com>
Subject: Re: [PATCH 19/23] twl4030-gpio: remove legacy irq triggering calls and user
Date: Tue, 30 Sep 2008 10:37:20 -0700 [thread overview]
Message-ID: <200809301037.21294.david-b@pacbell.net> (raw)
In-Reply-To: <1222769160-31615-20-git-send-email-felipe.balbi@nokia.com>
Here's an important bugfix ... strictly speaking the bug was
introduced in patch #18, but rather than redo both patches
I think it's simpler to just merge this one-liner here where
it could first have been noticed.
With this, I can confirm I've actually seen TWL triggering
GPIO interrupts ... on the appropriate edge. At least,
when using GPIO-1, since I wasn't keen on trying to use
GPIO-0 to report removal of my SD-resident rootfs. ;)
--- beagle.orig/drivers/gpio/twl4030-gpio.c 2008-09-30 10:28:25.000000000 -0700
+++ beagle/drivers/gpio/twl4030-gpio.c 2008-09-30 10:28:18.000000000 -0700
@@ -652,7 +652,8 @@ static int twl4030_gpio_unmask_thread(vo
type = desc->status & IRQ_TYPE_SENSE_MASK;
spin_unlock_irq(&desc->lock);
- twl4030_set_gpio_edge_ctrl(irq, type);
+ twl4030_set_gpio_edge_ctrl(irq - twl4030_gpio_irq_base,
+ type);
}
local_irq_disable();
next prev parent reply other threads:[~2008-09-30 17:37 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-09-30 10:05 [PATCH 00/23] twl4030 patches (v4) Felipe Balbi
2008-09-30 10:05 ` [PATCH 01/23] twl4030: fix potential null pointer dereference Felipe Balbi
2008-09-30 10:05 ` [PATCH 02/23] twl4030-gpio: Remove default pullup enable/disable of GPIO Felipe Balbi
2008-09-30 10:05 ` [PATCH 03/23] i2c: clean add_children a bit Felipe Balbi
2008-09-30 10:05 ` [PATCH 04/23] i2c: move twl4030_keypad to new style registration Felipe Balbi
2008-09-30 10:05 ` [PATCH 05/23] i2c: move twl4030-usb to platform_device Felipe Balbi
2008-09-30 10:05 ` [PATCH 06/23] i2c: twl4030-usb: add 'vbus' sysfs file Felipe Balbi
2008-09-30 10:05 ` [PATCH 07/23] twl4030 gpio platform data Felipe Balbi
2008-09-30 10:05 ` [PATCH 08/23] twl4030 uses gpiolib Felipe Balbi
2008-09-30 10:05 ` [PATCH 09/23] i2c: move twl4030-madc to new registration style Felipe Balbi
2008-09-30 10:05 ` [PATCH 10/23] minor twl4030-core cleanups Felipe Balbi
2008-09-30 10:05 ` [PATCH 11/23] provide detailed diagnostics in add_children() Felipe Balbi
2008-09-30 10:05 ` [PATCH 12/23] move twl4030-gpio to drivers/gpio Felipe Balbi
2008-09-30 10:05 ` [PATCH 13/23] i2c: added a few missing gotos to add_children() Felipe Balbi
2008-09-30 10:05 ` [PATCH 14/23] minor irq-related cleanups Felipe Balbi
2008-09-30 10:05 ` [PATCH 15/23] i2c: switch twl4030-usb to use a resource for irq Felipe Balbi
2008-09-30 10:05 ` [PATCH 16/23] Move I2C driver model init earlier in the boot sequence Felipe Balbi
2008-09-30 10:05 ` [PATCH 17/23] i2c: minor cleanups to twl4030-pwrbutton.c Felipe Balbi
2008-09-30 10:05 ` [PATCH 18/23] twl4030-gpio irq_chip.set_type Felipe Balbi
2008-09-30 10:05 ` [PATCH 19/23] twl4030-gpio: remove legacy irq triggering calls and user Felipe Balbi
2008-09-30 10:05 ` [PATCH 20/23] twl4030-gpio: irq and other cleanup Felipe Balbi
2008-09-30 10:05 ` [PATCH 21/23] twl4030-core: portability updates Felipe Balbi
2008-09-30 10:05 ` [PATCH 22/23] twl4030: minor cleanups to twl4030_bci_battery.c Felipe Balbi
2008-09-30 10:06 ` [PATCH 23/23] twl4030-bci: move to new style registration method Felipe Balbi
2008-09-30 17:37 ` David Brownell [this message]
2008-09-30 15:52 ` [PATCH 16/23] Move I2C driver model init earlier in the boot sequence David Brownell
2008-09-30 13:05 ` [PATCH 00/23] twl4030 patches (v4) Tony Lindgren
2008-09-30 16:26 ` Steve Sakoman
2008-09-30 17:37 ` Felipe Balbi
2008-09-30 18:12 ` Steve Sakoman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200809301037.21294.david-b@pacbell.net \
--to=david-b@pacbell.net \
--cc=felipe.balbi@nokia.com \
--cc=linux-omap@vger.kernel.org \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox