From: Mark Brown <broonie@sirena.org.uk>
To: Arun KS <arunks@mistralsolutions.com>
Cc: alsa-devel@alsa-project.org,
"linux-omap@vger.kernel.org List" <linux-omap@vger.kernel.org>,
Jarkko Nikula <jarkko.nikula@nokia.com>,
felipe.balbi@nokia.com
Subject: Re: [PATCH 1/5 v1] ASoC Add TLV320AIC23 codec driver
Date: Tue, 30 Sep 2008 12:02:56 +0100 [thread overview]
Message-ID: <20080930110255.GE19862@sirena.org.uk> (raw)
In-Reply-To: <dfeb90390809300347o4b386cffrb78c282f41e68fe9@mail.gmail.com>
On Tue, Sep 30, 2008 at 04:17:38PM +0530, Arun KS wrote:
> On Tue, Sep 30, 2008 at 3:49 PM, Mark Brown <broonie@sirena.org.uk> wrote:
> > There are no routes here for your bypass path(s) - this will mean that
> > DAPM won't power them on unless there's an active playback and record.
> > At present that's fine for digital only bypass paths but if there are
> > analogue ones they should be visible here.
> I made the bypass and sidetone as controls. The user can switchon them
> through amixer controls.
Right, they should be visible DAPM controls to allow user control.
> sh-3.00# amixer cset numid=9 1
> numid=9,iface=MIXER,name='Line Bypass'
> ; type=BOOLEAN,access=rw------,values=1
> : values=on
> sh-3.00# amixer cset numid=11 1
> numid=11,iface=MIXER,name='PGA Mixer Line Switch'
> ; type=BOOLEAN,access=rw------,values=1
> : values=on
> Its working.
Hrm. That suggests that there's a bug in the power management
somewhere - without routes DAPM won't know to power up any of the output
stages when the bypass paths are in use, leaving them unpowered.
Note that a lot of PGAs will pass through audio when powered down so you
need to check that things like mute and gain controls are functioning as
expected rather than just testing for the presence of a signal. Then
again, looking at your driver again I don't see any power managent for
the output stages either...
You can see what DAPM is powering up by looking at:
/sys/bus/platform/devices/soc-audio/dapm_widgets
Even if this works within the device DAPM still needs to know about the
bypass paths so that it can manage components outside the codec.
prev parent reply other threads:[~2008-09-30 11:02 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-09-30 9:59 [PATCH 1/5 v1] ASoC Add TLV320AIC23 codec driver Arun KS
2008-09-30 10:19 ` Mark Brown
2008-09-30 10:47 ` Arun KS
2008-09-30 11:02 ` Mark Brown [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080930110255.GE19862@sirena.org.uk \
--to=broonie@sirena.org.uk \
--cc=alsa-devel@alsa-project.org \
--cc=arunks@mistralsolutions.com \
--cc=felipe.balbi@nokia.com \
--cc=jarkko.nikula@nokia.com \
--cc=linux-omap@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox