From: David Brownell <david-b@pacbell.net>
To: Nathan Monson <nmonson@gmail.com>
Cc: linux-omap@vger.kernel.org
Subject: Re: [patch 2.6.27-rc7-omap1-git 1/2] twl4030-core: move to drivers/mfd
Date: Fri, 3 Oct 2008 17:00:37 -0700 [thread overview]
Message-ID: <200810031700.38008.david-b@pacbell.net> (raw)
In-Reply-To: <e5e6ade50810031631q59e527b7ke0e8787a857165f2@mail.gmail.com>
On Friday 03 October 2008, Nathan Monson wrote:
> > http://marc.info/?l=linux-omap&m=122297833314280&w=2
> >
> > commenting on the issue I noted when I posted this patch;
> > showing how I work around that specific I2C error. It'd
> > likely work for you too.
>
> Thanks for pointing this out. The retry patch earlier in the thread
> fixes the problem.
>
> On 5 test boots I received the "i2c_omap i2c_omap.1: controller timed
> out" message all 5 times, but it recovers and seems to work fine.
That's good news.
Now, I'll hope someone more in touch with the I2C hardware
can take a look at drivers/i2c/busses/i2c-omap.c and suggest
some way to stop getting this error ... nice that it's rather
reproducible, if one were to debug it!
As I noted in the message above, I see this error in other
cases too. All of them "of course" should be made to handle
such faults better. But virtually nothing in the I2C stack
does sane fault handling, so we also need the i2c-omap code
to stop misbehaving.
- Dave
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2008-10-04 0:00 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-02 2:47 [patch 2.6.27-rc7-omap1-git 1/2] twl4030-core: move to drivers/mfd David Brownell
2008-10-02 9:07 ` Felipe Balbi
2008-10-02 14:52 ` David Brownell
2008-10-02 14:53 ` Felipe Balbi
2008-10-03 13:37 ` Tony Lindgren
2008-10-03 20:12 ` Nathan Monson
2008-10-03 22:16 ` David Brownell
2008-10-03 23:31 ` Nathan Monson
2008-10-04 0:00 ` David Brownell [this message]
2008-10-02 19:47 ` David Brownell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200810031700.38008.david-b@pacbell.net \
--to=david-b@pacbell.net \
--cc=linux-omap@vger.kernel.org \
--cc=nmonson@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox