RE: OMAP support in mainline?

RE: OMAP support in mainline?

[Nathan Monson]

On Thu, Sep 18, 2008 at 3:26PM, Felipe Balbi wrote:
> Yeah, we lost some musb history when it went to mainline. I didn't test
> this patch yet cuz I've been quite busy at work, but it should make
> beagle work. Could you tell me if makes it work ?

This patch has been working for me until the latest round of twl4030 changes.

Commit fde13f8fc7de977e71304fd500fed029b41ceb19/"move twl4030-usb to
platform-device" changed subsys_initcall to module_init in
twl4030-usb.

Now, twl4030-usb is initialized after musb.  This means
otg_set_transceiver is called later in boot, so the patch below gets
null back from otg_get_transceiver and oopses on *xceiv.

Unfortunately, without the patch, USB host doesn't work on the BeagleBoard.

Other than this, the new kernel seems to work pretty well for me.

- Nathan

> diff --git a/drivers/usb/musb/omap2430.c b/drivers/usb/musb/omap2430.c
> index 9d2dcb1..f7fe91e 100644
> --- a/drivers/usb/musb/omap2430.c
> +++ b/drivers/usb/musb/omap2430.c
> @@ -215,12 +215,14 @@ void musb_platform_set_mode(struct musb *musb, u8 musb_mode)
>
> int __init musb_platform_init(struct musb *musb)
> {
> +       struct otg_transceiver *xceiv = otg_get_transceiver();
> u32 l;
>
> #if defined(CONFIG_ARCH_OMAP2430)
> omap_cfg_reg(AE5_2430_USB0HS_STP);
> #endif
>
> +       memcpy(musb->xceiv, xceiv, sizeof(*xceiv));
> musb_platform_resume(musb);
>
> l = omap_readl(OTG_SYSCONFIG);

Re: OMAP support in mainline?

[Felipe Balbi]

On Fri, Oct 03, 2008 at 12:20:56AM -0700, Nathan Monson wrote:
> On Thu, Sep 18, 2008 at 3:26PM, Felipe Balbi wrote:
> > Yeah, we lost some musb history when it went to mainline. I didn't test
> > this patch yet cuz I've been quite busy at work, but it should make
> > beagle work. Could you tell me if makes it work ?
> 
> This patch has been working for me until the latest round of twl4030 changes.
> 
> Commit fde13f8fc7de977e71304fd500fed029b41ceb19/"move twl4030-usb to
> platform-device" changed subsys_initcall to module_init in
> twl4030-usb.
> 
> Now, twl4030-usb is initialized after musb.  This means
> otg_set_transceiver is called later in boot, so the patch below gets
> null back from otg_get_transceiver and oopses on *xceiv.
> 
> Unfortunately, without the patch, USB host doesn't work on the BeagleBoard.
> 
> Other than this, the new kernel seems to work pretty well for me.

Dave, this will be fixed when i2c with your patch initializing i2c
earlier on boot. Right ?

For now, let's keep subsys_initcall() on twl4030_usb. I'll prepare a
patch and send it really soon.

Thanks for notifying me Nathan.

-- 
balbi

Re: OMAP support in mainline?

[David Brownell]

On Friday 03 October 2008, Felipe Balbi wrote:
> On Fri, Oct 03, 2008 at 12:20:56AM -0700, Nathan Monson wrote:
> > On Thu, Sep 18, 2008 at 3:26PM, Felipe Balbi wrote:
> > > Yeah, we lost some musb history when it went to mainline. I didn't test
> > > this patch yet cuz I've been quite busy at work, but it should make
> > > beagle work. Could you tell me if makes it work ?
> > 
> > This patch has been working for me until the latest round of twl4030 changes.
> > 
> > Commit fde13f8fc7de977e71304fd500fed029b41ceb19/"move twl4030-usb to
> > platform-device" changed subsys_initcall to module_init in
> > twl4030-usb.
> > 
> > Now, twl4030-usb is initialized after musb.  This means
> > otg_set_transceiver is called later in boot, so the patch below gets
> > null back from otg_get_transceiver and oopses on *xceiv.
> > 
> > Unfortunately, without the patch, USB host doesn't work on the BeagleBoard.

I see it working ... there's a bit of oddness in a host-only config,
devices have to be plugged in after boot, but "doesn't work" seems
pretty wrong.

 
> > Other than this, the new kernel seems to work pretty well for me.
> 
> Dave, this will be fixed when i2c with your patch initializing i2c
> earlier on boot. Right ?

That's just driver model init, allowing i2c drivers to register
earlier, so subsys initcalls can rely on i2c to already have been
initialized ... so, no.

Within a given initcall level -- like subsys, or (later) driver -- the
initialization sequence is controlled by kernel link order, which is
a function of location in the source tree. 


> For now, let's keep subsys_initcall() on twl4030_usb. I'll prepare a
> patch and send it really soon.

That's the right longer-term answer, I think.

- Dave


> 
> Thanks for notifying me Nathan.
> 
> -- 
> balbi
> 
> 

[PATCH] i2c: change twl4030-usb back to subsys_initcall

[Felipe Balbi]

without it, otg_get/set_transceiver won't be useful and
twl4030-usb transceiver won't get to musb code.

Signed-off-by: Felipe Balbi <felipe.balbi@nokia.com>
---
 drivers/i2c/chips/twl4030-usb.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/i2c/chips/twl4030-usb.c b/drivers/i2c/chips/twl4030-usb.c
index 133cc0f..922d7d6 100644
--- a/drivers/i2c/chips/twl4030-usb.c
+++ b/drivers/i2c/chips/twl4030-usb.c
@@ -774,7 +774,7 @@ static int __init twl4030_usb_init(void)
 {
 	return platform_driver_register(&twl4030_driver);
 }
-module_init(twl4030_usb_init);
+subsys_init(twl4030_usb_init);
 
 static void __exit twl4030_usb_exit(void)
 {
-- 
1.6.0.2.307.gc427

Re: [PATCH] i2c: change twl4030-usb back to subsys_initcall

[Koen Kooi]

[-- Attachment #1: Type: text/plain, Size: 1121 bytes --]


Op 3 okt 2008, om 11:45 heeft Felipe Balbi het volgende geschreven:

> without it, otg_get/set_transceiver won't be useful and
> twl4030-usb transceiver won't get to musb code.

Is the 'fix-something' patch still needed, and if yes, why isn't it in  
l-o git yet?

regards,

Koen


>
>
> Signed-off-by: Felipe Balbi <felipe.balbi@nokia.com>
> ---
> drivers/i2c/chips/twl4030-usb.c |    2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/i2c/chips/twl4030-usb.c b/drivers/i2c/chips/ 
> twl4030-usb.c
> index 133cc0f..922d7d6 100644
> --- a/drivers/i2c/chips/twl4030-usb.c
> +++ b/drivers/i2c/chips/twl4030-usb.c
> @@ -774,7 +774,7 @@ static int __init twl4030_usb_init(void)
> {
> 	return platform_driver_register(&twl4030_driver);
> }
> -module_init(twl4030_usb_init);
> +subsys_init(twl4030_usb_init);
>
> static void __exit twl4030_usb_exit(void)
> {
> -- 
> 1.6.0.2.307.gc427
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux- 
> omap" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>


[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 186 bytes --]

Re: [PATCH] i2c: change twl4030-usb back to subsys_initcall

[Felipe Balbi]

On Fri, Oct 03, 2008 at 12:19:33PM +0200, ext Koen Kooi wrote:
>
> Op 3 okt 2008, om 11:45 heeft Felipe Balbi het volgende geschreven:
>
>> without it, otg_get/set_transceiver won't be useful and
>> twl4030-usb transceiver won't get to musb code.
>
> Is the 'fix-something' patch still needed, and if yes, why isn't it in l-o 
> git yet?

we need that otg_get/set_transceiver call, yes. But those are omap
specifc. there's a patch pending in linux-usb making those calls
generic.

I'd say we can keep a patch in l-o only untill otg_get/set_transceiver
hooks get accepted.

What say you Tony ?

-- 
balbi

Re: [PATCH] i2c: change twl4030-usb back to subsys_initcall

[Tony Lindgren]

* Felipe Balbi <felipe.balbi@nokia.com> [081003 15:05]:
> On Fri, Oct 03, 2008 at 12:19:33PM +0200, ext Koen Kooi wrote:
> >
> > Op 3 okt 2008, om 11:45 heeft Felipe Balbi het volgende geschreven:
> >
> >> without it, otg_get/set_transceiver won't be useful and
> >> twl4030-usb transceiver won't get to musb code.
> >
> > Is the 'fix-something' patch still needed, and if yes, why isn't it in l-o 
> > git yet?
> 
> we need that otg_get/set_transceiver call, yes. But those are omap
> specifc. there's a patch pending in linux-usb making those calls
> generic.
> 
> I'd say we can keep a patch in l-o only untill otg_get/set_transceiver
> hooks get accepted.
> 
> What say you Tony ?

Sure, we should keep things working for all the omap users while
waiting for the necessary stuff to get merged into mainline.

Felipe, just let me know what we need for l-o tree for musb.

Tony

Re: [PATCH] i2c: change twl4030-usb back to subsys_initcall

[Felipe Balbi]

On Fri, Oct 03, 2008 at 04:28:32PM +0300, Tony Lindgren wrote:
> * Felipe Balbi <felipe.balbi@nokia.com> [081003 15:05]:
> > On Fri, Oct 03, 2008 at 12:19:33PM +0200, ext Koen Kooi wrote:
> > >
> > > Op 3 okt 2008, om 11:45 heeft Felipe Balbi het volgende geschreven:
> > >
> > >> without it, otg_get/set_transceiver won't be useful and
> > >> twl4030-usb transceiver won't get to musb code.
> > >
> > > Is the 'fix-something' patch still needed, and if yes, why isn't it in l-o 
> > > git yet?
> > 
> > we need that otg_get/set_transceiver call, yes. But those are omap
> > specifc. there's a patch pending in linux-usb making those calls
> > generic.
> > 
> > I'd say we can keep a patch in l-o only untill otg_get/set_transceiver
> > hooks get accepted.
> > 
> > What say you Tony ?
> 
> Sure, we should keep things working for all the omap users while
> waiting for the necessary stuff to get merged into mainline.
> 
> Felipe, just let me know what we need for l-o tree for musb.

I'll send you a patch in a jiffy

-- 
balbi

Re: [PATCH] i2c: change twl4030-usb back to subsys_initcall

[Nathan Monson]

On Fri, Oct 3, 2008 at 2:45 AM, Felipe Balbi <felipe.balbi@nokia.com> wrote:
> without it, otg_get/set_transceiver won't be useful and
> twl4030-usb transceiver won't get to musb code.
>
> +subsys_init(twl4030_usb_init);

Should this be subsys_initcall?

- Nathan

Re: [PATCH] i2c: change twl4030-usb back to subsys_initcall

[Felipe Balbi]

On Fri, Oct 03, 2008 at 01:05:14PM -0700, Nathan Monson wrote:
> On Fri, Oct 3, 2008 at 2:45 AM, Felipe Balbi <felipe.balbi@nokia.com> wrote:
> > without it, otg_get/set_transceiver won't be useful and
> > twl4030-usb transceiver won't get to musb code.
> >
> > +subsys_init(twl4030_usb_init);
> 
> Should this be subsys_initcall?

Crap... good catch. Sorry for that. new one coming.

-- 
balbi

[PATCH] i2c: change twl4030-usb back to subsys_initcall

[Felipe Balbi]

without it, otg_get/set_transceiver won't be useful and
twl4030-usb transceiver won't get to musb code.

Signed-off-by: Felipe Balbi <felipe.balbi@nokia.com>
---
 drivers/i2c/chips/twl4030-usb.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/i2c/chips/twl4030-usb.c b/drivers/i2c/chips/twl4030-usb.c
index 133cc0f..922d7d6 100644
--- a/drivers/i2c/chips/twl4030-usb.c
+++ b/drivers/i2c/chips/twl4030-usb.c
@@ -774,7 +774,7 @@ static int __init twl4030_usb_init(void)
 {
 	return platform_driver_register(&twl4030_driver);
 }
-module_init(twl4030_usb_init);
+subsys_initcall(twl4030_usb_init);
 
 static void __exit twl4030_usb_exit(void)
 {
-- 
1.6.0.2.307.gc427

-- 
balbi

Re: OMAP support in mainline?

[Nathan Monson]

On Fri, Oct 3, 2008 at 1:36 AM, David Brownell <david-b@pacbell.net> wrote:
>> > Unfortunately, without the patch, USB host doesn't work on the BeagleBoard.
>
> I see it working ... there's a bit of oddness in a host-only config,
> devices have to be plugged in after boot, but "doesn't work" seems
> pretty wrong.

The secret is to unplug the A cable from the mini-AB port on the
Beagleboard.  I was un/replugging my cable from the hub repeatedly,
thinking it was broken.  But un/replugging from the mini-AB port makes
everything appear.  Thanks for the hint -- I was ready to give up.

- Nathan

Re: OMAP support in mainline?

[David Brownell]

On Friday 03 October 2008, Nathan Monson wrote:
> On Fri, Oct 3, 2008 at 1:36 AM, David Brownell <david-b@pacbell.net> wrote:
> >> > Unfortunately, without the patch, USB host doesn't work on the BeagleBoard.
> >
> > I see it working ... there's a bit of oddness in a host-only config,
> > devices have to be plugged in after boot, but "doesn't work" seems
> > pretty wrong.
> 
> The secret is to unplug the A cable from the mini-AB port on the
> Beagleboard.  I was un/replugging my cable from the hub repeatedly,
> thinking it was broken.  But un/replugging from the mini-AB port makes
> everything appear.  Thanks for the hint -- I was ready to give up.

Yeah, I was pleased to discover that trick!

Of course, it's supposed to work without the unplug step too.  :)

- Dave

Re: [PATCH] i2c: change twl4030-usb back to subsys_initcall

[Tony Lindgren]

* Felipe Balbi <me@felipebalbi.com> [081004 02:50]:
> without it, otg_get/set_transceiver won't be useful and
> twl4030-usb transceiver won't get to musb code.

Pushed to l-o tree.

Tony

> 
> Signed-off-by: Felipe Balbi <felipe.balbi@nokia.com>
> ---
>  drivers/i2c/chips/twl4030-usb.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/i2c/chips/twl4030-usb.c b/drivers/i2c/chips/twl4030-usb.c
> index 133cc0f..922d7d6 100644
> --- a/drivers/i2c/chips/twl4030-usb.c
> +++ b/drivers/i2c/chips/twl4030-usb.c
> @@ -774,7 +774,7 @@ static int __init twl4030_usb_init(void)
>  {
>  	return platform_driver_register(&twl4030_driver);
>  }
> -module_init(twl4030_usb_init);
> +subsys_initcall(twl4030_usb_init);
>  
>  static void __exit twl4030_usb_exit(void)
>  {
> -- 
> 1.6.0.2.307.gc427
> 
> -- 
> balbi
> --
> To unsubscribe from this list: send the line "unsubscribe linux-omap" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html